Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add contentType filter on site pages query #171

Closed
wants to merge 3 commits into from
Closed

Add contentType filter on site pages query #171

wants to merge 3 commits into from

Conversation

sks444
Copy link

@sks444 sks444 commented Apr 24, 2021 •
edited
Loading

Closes #170

@sks444 sks444 mentioned this pull request Apr 24, 2021
Closed
@zerolab
Copy link
Member

zerolab commented Apr 24, 2021

Thank you for this. Could you add a couple of tests too?

@sks444
Copy link
Author

sks444 commented Apr 25, 2021

@zerolab added tests for this.

zerolab
zerolab reviewed Apr 25, 2021
View reviewed changes
grapple/types/sites.py Outdated Show resolved Hide resolved
zerolab added a commit that referenced this pull request Apr 25, 2021
@zerolab
Add contentType filter on site pages query (#171)
cdc0d1d 
commit 963fae64468e4c7b2e1af9029ff4b691dc363559
Author: Dan Braghis <[email protected]>
Date:   Sun Apr 25 10:32:03 2021 +0100

    Lint

commit 64d7014
Author: Dan Braghis <[email protected]>
Date:   Sun Apr 25 10:18:58 2021 +0100

    Update grapple/types/sites.py

commit 1f83824
Author: sks444 <[email protected]>
Date:   Sun Apr 25 13:16:46 2021 +0530

    Add tests

commit 27f5595
Author: sks444 <[email protected]>
Date:   Sat Apr 24 18:04:55 2021 +0530

    Add contentType filter on site pages query
@zerolab
Copy link
Member

zerolab commented Apr 25, 2021 •
edited
Loading

LInted manually and merged in cdc0d1d. Thank you

@zerolab zerolab closed this Apr 25, 2021
@sks444
Copy link
Author

sks444 commented Apr 26, 2021

Thanks for the merge @zerolab!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerolab zerolab zerolab left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

contentType filter on a Page doesn't work
2 participants
@sks444 @zerolab