-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin non-primitive function parameters #87
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -71,14 +71,25 @@ export function bindExportFunction( | |||
`Expected ${argumentConverterFunctions.length} arguments, got ${args.length}` | |||
); | |||
} | |||
const newArgs = args.map((v, i) => | |||
argumentConverterFunctions[i]( | |||
// The conversion function of the _next_ parameter could potentially |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah! Thank you for the comment here! It's super helpful! 😄 🎉
@@ -0,0 +1,8 @@ | |||
exports.mangleCompilerParams = params => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the tests as well! 😄 🎉
@surma I can't seem to get Travis to be happy even though I did a whole new migration and things. 😭😭😭 Can you maybe sucking your local branch, closing this PR, and try opening a new PR and see if that works? 🤔 |
(Closing and re-opening to maybe make travis happy?) |
Finally found the travis issue: |
Found the issue 🙃 travis-ci/docs-travis-ci-com#733 (comment) |
Thanks for landing this @torch2424! Appreciate you taking care of that part! |
Fixes #85
cc @RehkitzDev