Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowed Accessing Unsafe Values from bound Asbind Functions #48

Merged
merged 4 commits into from
Oct 9, 2020
Merged

Allowed Accessing Unsafe Values from bound Asbind Functions #48

merged 4 commits into from
Oct 9, 2020

Conversation

torch2424
Copy link
Owner

closes #47
closes #9

This allows setting an unsafeReturnValue flag on functions, that will then return direct view on memory, instead of copying them out of memory. Please see the issues for context.

Screenshot from 2020-10-09 15-40-53

@torch2424 torch2424 added the enhancement New feature or request label Oct 9, 2020
@torch2424 torch2424 self-assigned this Oct 9, 2020
@torch2424 torch2424 changed the title Unsafe array views Allowed Accessing Unsafe Values from bound Asbind Functions Oct 9, 2020
torch2424
torch2424 commented Oct 9, 2020
View reviewed changes
Copy link
Owner Author

@torch2424 torch2424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a self-review, looks good! 😄 👍

@torch2424 torch2424 merged commit 21b1883 into master Oct 9, 2020
@torch2424 torch2424 deleted the unsafe-array-views branch October 9, 2020 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@torch2424 torch2424

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to access typed arrays by reference instead of copy Watch the AssemblyScript PR to remove .slice()
1 participant
@torch2424