🔊 Add metrics to log MM embedding time#899
Conversation
|
👋 Hi! Thank you for contributing to vLLM support on Spyre. We also recommend installing prek and configuring it to check your code before every local commit. |
Signed-off-by: Gaurav-Kumbhat <Gaurav.Kumbhat@ibm.com>
0c75c65 to
5525708
Compare
| logger.info("maybe_mm_embedding processing time: %.2fms", (t1 * 1000)) | ||
| logger.info("maybe_mm_embedding processing time: %.2fms", (t_elapsed * 1000)) | ||
| self.perf_logger.log( | ||
| "get_mm_embeddings_time_ms", |
There was a problem hiding this comment.
Do we need to be publishing a non-standard vllm metric here?
There was a problem hiding this comment.
I was trying to find a similar metric from vllm that we could reuse, or push the numbers there. Haven't found one yet..
The idea here is to have a way to measure impact of MM processing.
Open to suggestions, if there is a better and more standard way to deal with this.
There was a problem hiding this comment.
@joerunde actually usage of create_perf_metric_logger already handles the optional enablement of this metric. So this will only get printed if we pass VLLM_SPYRE_PERF_METRIC_LOGGING_ENABLED env variable.
|
ah shoot GK I forgot to hit merge last week, sorry! |
Description
Add metric to log mm embedding calculation time.
Related Issues
Test Plan
Checklist
bash format.sh)Signed-off-by:line (DCO compliance)