Skip to content

[Spyre-Next] [Bug] Fixed dtype for embedding#883

Merged
bohnstingl merged 1 commit intotorch-spyre:mainfrom
bohnstingl:embedding_dtype_fix
Apr 2, 2026
Merged

[Spyre-Next] [Bug] Fixed dtype for embedding#883
bohnstingl merged 1 commit intotorch-spyre:mainfrom
bohnstingl:embedding_dtype_fix

Conversation

@bohnstingl
Copy link
Copy Markdown
Collaborator

@bohnstingl bohnstingl commented Mar 31, 2026

Description

This PR ensures that the correct dtypes are used for spyre for the embedding layer.

cc @coderfornow

Related Issues

#753

Test Plan

I ran E2E test and confirmed they are working. Furthermore, we will use the current upstream tests that we have to check.

Checklist

  • I have read the contributing guidelines
  • My code follows the project's code style (run bash format.sh)
  • I have added tests for my changes (if applicable)
  • I have updated the documentation (if applicable)
  • My commits include a Signed-off-by: line (DCO compliance)

Signed-off-by: Thomas Ortner <boh@zurich.ibm.com>
@github-actions
Copy link
Copy Markdown

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, run ./format.sh.
Now you are good to go 🚀.

We also recommend installing prek and configuring it to check your code before every local commit.

@github-actions github-actions Bot changed the title [Bug] Fixed dtype for embedding [Spyre-Next] [Bug] Fixed dtype for embedding Mar 31, 2026
@bohnstingl bohnstingl requested review from coderfornow and removed request for joerunde and prashantgupta24 March 31, 2026 21:09
@bohnstingl
Copy link
Copy Markdown
Collaborator Author

bot:next-test

Copy link
Copy Markdown
Collaborator

@yannicks1 yannicks1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, did #836 never run on spyre or how come this went unnoticed?

Copy link
Copy Markdown
Collaborator

@coderfornow coderfornow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bohnstingl
Copy link
Copy Markdown
Collaborator Author

lgtm, did #836 never run on spyre or how come this went unnoticed?

@yannicks1 this is a good point.
@coderfornow can you confirm that this #836 (comment) was actually running on spyre?

@tjohnson31415 could you maybe confirm that the CI tests for this PR are failing because of a non-related issue?

@bohnstingl bohnstingl requested a review from tjohnson31415 April 1, 2026 10:02
@tjohnson31415
Copy link
Copy Markdown
Collaborator

@tjohnson31415 could you maybe confirm that the CI tests for this PR are failing because of a non-related issue?

Yes, that is correct. The spyre-ci tests are still in a broken state, so we don't need to have that block this PR

@bohnstingl bohnstingl requested a review from joerunde April 2, 2026 05:15
@bohnstingl
Copy link
Copy Markdown
Collaborator Author

I tested this PR locally and it worked. The CI tests are currently broken, but a solution is in the making.

@bohnstingl bohnstingl merged commit 6917cc1 into torch-spyre:main Apr 2, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants