[Spyre-Next] [Bug] Fixed dtype for embedding#883
Conversation
Signed-off-by: Thomas Ortner <boh@zurich.ibm.com>
|
👋 Hi! Thank you for contributing to vLLM support on Spyre. We also recommend installing prek and configuring it to check your code before every local commit. |
|
bot:next-test |
@yannicks1 this is a good point. @tjohnson31415 could you maybe confirm that the CI tests for this PR are failing because of a non-related issue? |
Yes, that is correct. The spyre-ci tests are still in a broken state, so we don't need to have that block this PR |
|
I tested this PR locally and it worked. The CI tests are currently broken, but a solution is in the making. |
Description
This PR ensures that the correct dtypes are used for spyre for the embedding layer.
cc @coderfornow
Related Issues
#753
Test Plan
I ran E2E test and confirmed they are working. Furthermore, we will use the current upstream tests that we have to check.
Checklist
bash format.sh)Signed-off-by:line (DCO compliance)