Update vllm to include 0.18.1#882
Conversation
|
👋 Hi! Thank you for contributing to vLLM support on Spyre. We also recommend installing prek and configuring it to check your code before every local commit. |
Signed-off-by: Daniel Schenker <daniel.schenker@ibm.com>
0f02333 to
e46c735
Compare
vLLM is built from source so there's another spot with the version: After you update that line too, |
Signed-off-by: Daniel Schenker <daniel.schenker@ibm.com>
That did the trick. Thanks @tjohnson31415 |
|
bot:test |
1 similar comment
|
bot:test |
There was a problem hiding this comment.
I believe https://github.com/vllm-project/vllm-spyre/blob/main/.github/workflows/test.yml#L77 should be updated too
|
🤔 In this case 0.18.0 is still the lower bound since we didn't pull it up, so the |
|
bot:test |
tjohnson31415
left a comment
There was a problem hiding this comment.
spyre-ci tests passed
Normally we would bump the lower bound, but it doesn't really matter when there are no code changes / compat to deal with.
LGTM
Description
This PR updates the vllm upper bound in pyproject.toml to include version 0.18.1.
Questions:
<operator and moved the upper bound to0.18.2to abide by the comment that is there. If that was the wrong choice let me know and I can switch it to<=0.18.1.uv sync --upgrade-package vllmbut nothing in uv.lock changed... Is there something else I should run instead?Related Issues
Test Plan
Checklist
bash format.sh)Signed-off-by:line (DCO compliance)