Skip to content

Update vllm to include 0.18.1#882

Merged
joerunde merged 2 commits intotorch-spyre:mainfrom
Daniel-Schenker:bump-vllm-upper-bound
Apr 1, 2026
Merged

Update vllm to include 0.18.1#882
joerunde merged 2 commits intotorch-spyre:mainfrom
Daniel-Schenker:bump-vllm-upper-bound

Conversation

@Daniel-Schenker
Copy link
Copy Markdown
Collaborator

Description

This PR updates the vllm upper bound in pyproject.toml to include version 0.18.1.

Questions:

  1. I kept it as a < operator and moved the upper bound to 0.18.2 to abide by the comment that is there. If that was the wrong choice let me know and I can switch it to <=0.18.1.
  2. I ran a uv sync --upgrade-package vllm but nothing in uv.lock changed... Is there something else I should run instead?

Related Issues

Test Plan

Checklist

  • I have read the contributing guidelines
  • My code follows the project's code style (run bash format.sh)
  • I have added tests for my changes (if applicable)
  • I have updated the documentation (if applicable)
  • My commits include a Signed-off-by: line (DCO compliance)

@github-actions
Copy link
Copy Markdown

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, run ./format.sh.
Now you are good to go 🚀.

We also recommend installing prek and configuring it to check your code before every local commit.

Signed-off-by: Daniel Schenker <daniel.schenker@ibm.com>
@tjohnson31415
Copy link
Copy Markdown
Collaborator

I ran a uv sync --upgrade-package vllm but nothing in uv.lock changed...

vLLM is built from source so there's another spot with the version:
https://github.com/vllm-project/vllm-spyre/blob/85924e4b9fe91ecce7e023e892938a222bdc6d53/pyproject.toml#L87

After you update that line too, uv sync should bring in updates to uv.lock.

Signed-off-by: Daniel Schenker <daniel.schenker@ibm.com>
@Daniel-Schenker
Copy link
Copy Markdown
Collaborator Author

I ran a uv sync --upgrade-package vllm but nothing in uv.lock changed...

vLLM is built from source so there's another spot with the version:

https://github.com/vllm-project/vllm-spyre/blob/85924e4b9fe91ecce7e023e892938a222bdc6d53/pyproject.toml#L87

After you update that line too, uv sync should bring in updates to uv.lock.

That did the trick. Thanks @tjohnson31415

@joerunde
Copy link
Copy Markdown
Collaborator

bot:test
MARKERS="spyre and prefix_caching and not multi"

1 similar comment
@joerunde
Copy link
Copy Markdown
Collaborator

joerunde commented Apr 1, 2026

bot:test
MARKERS="spyre and prefix_caching and not multi"

Copy link
Copy Markdown
Collaborator

@rafvasq rafvasq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joerunde
Copy link
Copy Markdown
Collaborator

joerunde commented Apr 1, 2026

🤔 In this case 0.18.0 is still the lower bound since we didn't pull it up, so the vLLM:lowest entry should probably remain as 0.18.0?

@joerunde
Copy link
Copy Markdown
Collaborator

joerunde commented Apr 1, 2026

bot:test
MARKERS="spyre and chunked_prefill"

Copy link
Copy Markdown
Collaborator

@tjohnson31415 tjohnson31415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spyre-ci tests passed
Normally we would bump the lower bound, but it doesn't really matter when there are no code changes / compat to deal with.

LGTM

@joerunde joerunde merged commit 9907dfd into torch-spyre:main Apr 1, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants