Update lower bound for fms to 1.8.0#879
Merged
joerunde merged 2 commits intotorch-spyre:mainfrom Mar 31, 2026
Merged
Conversation
Signed-off-by: Daniel Schenker <daniel.schenker@ibm.com>
Daniel-Schenker
requested review from
joerunde and
prashantgupta24
as code owners
|
👋 Hi! Thank you for contributing to vLLM support on Spyre. We also recommend installing prek and configuring it to check your code before every local commit. |
joerunde
reviewed
Mar 30, 2026
| name = "vllm" | ||
| version = "0.18.0" | ||
| source = { git = "https://github.com/vllm-project/vllm?rev=v0.18.0#89138b21cc246ae944c741d5c399c148e2b770ab" } | ||
| source = { git = "https://github.com/vllm-project/vllm?rev=v0.18.0#bcf2be96120005e9aea171927f85055a6a5c0cf6" } |
Collaborator
There was a problem hiding this comment.
NB for readers, this commit was somehow incorrect before
Collaborator
|
bot:test |
Signed-off-by: Daniel Schenker <daniel.schenker@ibm.com>
Daniel-Schenker
force-pushed
the
bump-fms-lower-bound
branch
from
afe3b49 to
2c3a5ad
Compare
Collaborator
|
bot:test |
Collaborator
|
bot:test |
Collaborator
|
bot:test |
joerunde
approved these changes
Mar 31, 2026
Collaborator
joerunde
left a comment
joerunde
left a comment
There was a problem hiding this comment.
lpgtm, tests all pass!
dilipgb
pushed a commit
to dilipgb/vllm-spyre
that referenced
this pull request
Mar 31, 2026
<!-- markdownlint-disable --> ## Description This PR bumps the lower bound of foundation-model-stack dependency from 1.7.0 to 1.8.0 which includes Llama bug fixes for torch 2.10. ## Related Issues <!-- Link related issues, e.g., `Fixes #` or `Relates to torch-spyre#456` --> ## Test Plan <!-- Describe how you tested your changes. Include commands or steps to reproduce. --> ## Checklist - [ ] I have read the [contributing guidelines](https://docs.vllm.ai/projects/spyre/en/latest/contributing) - [ ] My code follows the project's code style (run `bash format.sh`) - [ ] I have added tests for my changes (if applicable) - [ ] I have updated the documentation (if applicable) - [ ] My commits include a `Signed-off-by:` line (DCO compliance) --------- Signed-off-by: Daniel Schenker <daniel.schenker@ibm.com> Signed-off-by: Dilip Gowda Bhagavan <dilip.bhagavan@ibm.com>
dilipgb
pushed a commit
to dilipgb/vllm-spyre
that referenced
this pull request
Apr 3, 2026
<!-- markdownlint-disable --> This PR bumps the lower bound of foundation-model-stack dependency from 1.7.0 to 1.8.0 which includes Llama bug fixes for torch 2.10. <!-- Link related issues, e.g., `Fixes #` or `Relates to torch-spyre#456` --> <!-- Describe how you tested your changes. Include commands or steps to reproduce. --> - [ ] I have read the [contributing guidelines](https://docs.vllm.ai/projects/spyre/en/latest/contributing) - [ ] My code follows the project's code style (run `bash format.sh`) - [ ] I have added tests for my changes (if applicable) - [ ] I have updated the documentation (if applicable) - [ ] My commits include a `Signed-off-by:` line (DCO compliance) --------- Signed-off-by: Daniel Schenker <daniel.schenker@ibm.com> Signed-off-by: Dilip Gowda Bhagavan <dilip.bhagavan@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR bumps the lower bound of foundation-model-stack dependency from 1.7.0 to 1.8.0 which includes Llama bug fixes for torch 2.10.
Related Issues
Test Plan
Checklist
bash format.sh)Signed-off-by:line (DCO compliance)