Skip to content

fix: don't use check on generated _version#852

Merged
joerunde merged 3 commits intotorch-spyre:mainfrom
tjohnson31415:fix-version-check
Mar 19, 2026
Merged

fix: don't use check on generated _version#852
joerunde merged 3 commits intotorch-spyre:mainfrom
tjohnson31415:fix-version-check

Conversation

@tjohnson31415
Copy link
Copy Markdown
Collaborator

@tjohnson31415 tjohnson31415 commented Mar 19, 2026

Description

setuptools_scm v10 no longer generates a _version file by default. We should be using importlib anyways though.

Related Issues

Test Plan

Manually verified both methods of obtaining the verion match:

from vllm_spyre._version import version as vllm_spyre_version
import importlib.metadata

vllm_spyre_version == importlib.metadata.version("vllm_spyre")

Also did a quick test with a manually generated precompiled model.

Signed-off-by: Travis Johnson <tsjohnso@us.ibm.com>
Copy link
Copy Markdown
Collaborator

@joerunde joerunde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lpgtm!

@joerunde joerunde enabled auto-merge (squash) March 19, 2026 18:29
@github-actions
Copy link
Copy Markdown

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, run ./format.sh.
Now you are good to go 🚀.

We also recommend installing prek and configuring it to check your code before every local commit.

Signed-off-by: Travis Johnson <tsjohnso@us.ibm.com>
@github-actions github-actions bot added the ready Runs the full CI test suite. Only add to PRs once ready to merge to limit public GHA usage label Mar 19, 2026
Signed-off-by: Travis Johnson <tsjohnso@us.ibm.com>
@joerunde joerunde disabled auto-merge March 19, 2026 20:18
@joerunde joerunde merged commit 02168dc into torch-spyre:main Mar 19, 2026
12 of 13 checks passed
@tjohnson31415 tjohnson31415 deleted the fix-version-check branch March 19, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Runs the full CI test suite. Only add to PRs once ready to merge to limit public GHA usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants