-
Notifications
You must be signed in to change notification settings - Fork 54
[Spyre-Next] RMSNorm tests and upstream tests framework #837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
2ef5ebf
v1 rms test
romitjain 91692ec
Updated tests
romitjain 9289830
Updates
romitjain a244e52
[Spyre-Next][Spyre] ci: add workflow to run uv lock --check (#784)
tjohnson31415 bfd54ac
[Spyre-Next] Rework rms_norm layer (#789)
joerunde 8e9d7cf
[Spyre-Next] Run upstream vLLM tests with pytest (#800)
tjohnson31415 298945c
yaml based filtering
romitjain d87e839
small updates
romitjain 042380e
Local rms norm tests working
romitjain 1b6256b
Upstream tests working
romitjain 63402fd
Formating changes
romitjain 7b81940
Addressed PR comments around spyre test and pytest plugin marker regi…
romitjain 8d1446d
Updated pytest plugin to move to cache based approach for vllm repo
romitjain c8bc9d3
Lint fixes
romitjain 865300f
Small updates
romitjain 9d803bd
Clean test selection and pyproject toml updates
romitjain f6ef6d3
Updated gaurd in silu
romitjain ab15448
Updated uv lock
romitjain cd4d96f
:bug: reorder tests, use model tests
joerunde 250e434
:art: fmt, uses_subprocess marker
joerunde 0e9c0be
:sparkles: add param allowlists
joerunde d9de933
:art: fmt
joerunde e3b9159
raise on invalid upstream tests yaml and a little cleanup
tjohnson31415 85713e7
:bug: get version from importlib
joerunde File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,6 +25,12 @@ dynamic = ["version"] | |
| [project.entry-points."vllm.platform_plugins"] | ||
| spyre_next = "vllm_spyre_next:register" | ||
|
|
||
| [project.entry-points."vllm.general_plugins"] | ||
| spyre_next_ops = "vllm_spyre_next:register_ops" | ||
|
|
||
| [project.entry-points."pytest11"] | ||
| spyre_next_test = "vllm_spyre_next.testing.pytest_plugin" | ||
|
|
||
| [tool.setuptools.packages.find] | ||
| where = ["."] # list of folders that contain the packages (["."] by default) | ||
| include = ["vllm_spyre_next*"] # package names should match these glob patterns (["*"] by default) | ||
|
|
@@ -88,10 +94,9 @@ extra-build-variables = { vllm = { VLLM_TARGET_DEVICE = "cpu" } } | |
| # vLLM and torch-spyre must be pulled from github to be built from source | ||
| # NB: torch-spyre can only be compiled where `sendnn` is available | ||
| [tool.uv.sources] | ||
| # This is the unreleased v0.16.0 tag with 2.10 support | ||
| vllm = { git = "https://github.com/vllm-project/vllm", rev = "2d5be1dd5ce2e44dfea53ea03ff61143da5137eb" } | ||
| vllm = { git = "https://github.com/vllm-project/vllm", rev = "v0.17.1" } | ||
| # see https://github.com/torch-spyre/torch-spyre/pull/746 | ||
| torch-spyre = { git = "https://github.com/torch-spyre/torch-spyre", rev = "bd7502baa9123d292e56dbd4928147969ecdf63c" } | ||
| torch-spyre = { git = "https://github.com/torch-spyre/torch-spyre", rev = "c1f67bb4701630179d53dbfc060dde62fc2d7d18" } | ||
| torch = [ | ||
| { index = "pytorch-cpu" }, | ||
| ] | ||
|
|
@@ -190,7 +195,6 @@ asyncio_default_fixture_loop_scope = "function" | |
| filterwarnings = [ | ||
| "ignore::_pytest.warning_types.PytestUnknownMarkWarning" | ||
| ] | ||
| addopts = "-m 'spyre or upstream_passing'" | ||
|
|
||
| # --8<-- [start:test-markers-definition] | ||
| markers = [ | ||
|
|
@@ -222,7 +226,8 @@ plugins.md007.indent = 4 | |
|
|
||
| [dependency-groups] | ||
| dev = [ | ||
| "pytest" | ||
| "pytest", | ||
| "pyyaml", | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
edit- I always thought |
||
| ] | ||
| upstream-tests = [ | ||
| "albumentations>=1.4.6", | ||
|
|
||
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.