[WIP][Spyre-Next] SpyreRMSNorm tests#830
Closed
sducouedic wants to merge 8 commits intotorch-spyre:mainfrom
Closed
[WIP][Spyre-Next] SpyreRMSNorm tests#830sducouedic wants to merge 8 commits intotorch-spyre:mainfrom
sducouedic wants to merge 8 commits intotorch-spyre:mainfrom
Conversation
added 4 commits
March 11, 2026 21:47
Signed-off-by: Sophie du Couédic <sop@ibm.zurich.com>
Signed-off-by: Sophie du Couédic <sop@ibm.zurich.com>
Signed-off-by: Sophie du Couédic <sop@ibm.zurich.com>
|
👋 Hi! Thank you for contributing to vLLM support on Spyre. We also recommend installing prek and configuring it to check your code before every local commit. |
added 3 commits
March 12, 2026 12:59
Signed-off-by: Sophie du Couédic <sop@ibm.zurich.com>
Signed-off-by: Sophie du Couédic <sop@ibm.zurich.com>
Signed-off-by: Sophie du Couédic <sop@ibm.zurich.com>
1 task
Signed-off-by: Sophie du Couédic <sop@zurich.ibm.com>
Collaborator
Author
|
There is an alternative implementation: #837 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds tests for SpyreRMSNorm CustomOp: it compares the spyre output with reference RMSNorm operator running on cpu.
Work in progress:
The test currently isn't passing, the output shape is different
AssertionError: The values for attribute 'shape' do not match: torch.Size([4096]) != torch.Size([1024, 4096])Need to figure out if the bug is in SpyreRMSNorm implementation or in the testRelated Issues
Fixes #805
Test Plan
pytest tests/test_spyre_rmsnorm.py::test_spyre_rms_norm -xsvChecklist
bash format.sh)Signed-off-by:line (DCO compliance)