Merged
Conversation
Signed-off-by: Joe Runde <joe@joerun.de>
|
👋 Hi! Thank you for contributing to vLLM support on Spyre. Or this can be done with Now you are good to go 🚀 |
Signed-off-by: Joe Runde <joe@joerun.de>
tdoublep
approved these changes
Jul 11, 2025
Collaborator
|
bot:test |
Collaborator
|
bot:test |
Signed-off-by: Prashant Gupta <prashantgupta@us.ibm.com>
Signed-off-by: Prashant Gupta <prashantgupta@us.ibm.com>
Collaborator
|
actually let me try to see if CB works with TP first before merging - edit: doesn't seem to work |
rafvasq
pushed a commit
to rafvasq/sendnn-inference
that referenced
this pull request
Mar 11, 2026
Signed-off-by: waleedqk <waleedqk@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug introduced in #283 where the non-driver workers did not cache the output tokens for the next decode iteration.
This also allows TP tests with TP=2 to run on cpu, so that we can catch these bugs on GHA runs.