Skip to content

🎨 Remove new_token_ids from warmup #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
prashantgupta24 wants to merge 8 commits into from
Closed

🎨 Remove new_token_ids from warmup #292

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
83059cb
🔥 remove new_token_ids from warmup decode
prashantgupta24 Jul 8, 2025
a9f34c8
🔥 remove new_token_ids from sb warmup too
prashantgupta24 Jul 9, 2025
99aad58
🙈 ignore the random type error
prashantgupta24 Jul 9, 2025
dcb8f0c
🎨 make it consistent
prashantgupta24 Jul 9, 2025
a4a188f
🚧
prashantgupta24 Jul 30, 2025
b00f92e
Merge remote-tracking branch 'upstream/main' into fix-092-compiler-bug
prashantgupta24 Jul 30, 2025
fa34d66
Merge remote-tracking branch 'upstream/main' into fix-092-compiler-bug
prashantgupta24 Jul 30, 2025
fd699ef
🐛 whoops
prashantgupta24 Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 3 additions & 15 deletions vllm_spyre/v1/worker/spyre_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,8 +363,7 @@ def _warmup_spyre_dynamic_size(self, special_token_ids):
with _maybe_warmup_context():
self._dynamic_warmup(dummy_requests=dummy_requests,
prompt_len=prompt_len,
batch_size=batch_size,
valid_token_ids_tensor=valid_token_ids_tensor)
batch_size=batch_size)

# warmup_mode completes the graph compilation, but we need to do
# one additional prefill to deploy the compiled program to the device,
Expand Down Expand Up @@ -466,22 +465,17 @@ def _warmup_spyre_fixed_size(self, prompt_len, num_decode_tokens,

# Set up dummy cached_requests for decode steps
req_ids = []
new_token_ids = []
new_block_ids = []
num_computed_tokens = []
for req in dummy_requests:
req_ids.append(req.req_id)
new_token_ids.append([
valid_token_ids_tensor[torch.randint(
0, len(valid_token_ids_tensor), (1, )).item()]
]) # placeholder token
new_block_ids.append([req.block_ids])
num_computed_tokens.append(req.num_computed_tokens)

cached_request_data = CachedRequestData(
req_ids=req_ids,
resumed_from_preemption=False,
new_token_ids=new_token_ids,
new_token_ids=[[] for _ in range(len(dummy_requests))],
new_block_ids=new_block_ids,
num_computed_tokens=num_computed_tokens,
)
Expand Down Expand Up @@ -542,7 +536,6 @@ def _dynamic_warmup(
dummy_requests: list[NewRequestData],
prompt_len: int,
batch_size: int,
valid_token_ids_tensor: torch.Tensor,
) -> None:

assert (
Expand All @@ -569,21 +562,16 @@ def _dynamic_warmup(

# one decode iteration across all sequences
req_ids = []
new_token_ids = []
new_block_ids = []
num_computed_tokens = []
for req in dummy_requests:
req_ids.append(req.req_id)
new_token_ids.append([
valid_token_ids_tensor[torch.randint(
0, len(valid_token_ids_tensor), (1, )).item()]
]) # placeholder token
new_block_ids.append([req.block_ids])
num_computed_tokens.append(prompt_len)
cached_request_data = CachedRequestData(
req_ids=req_ids,
resumed_from_preemption=False,
new_token_ids=new_token_ids,
new_token_ids=[[] for _ in range(len(dummy_requests))],
new_block_ids=new_block_ids,
num_computed_tokens=num_computed_tokens,
)
Expand Down