Skip to content

Do not merge#280

Closed
maxdebayser wants to merge 17 commits intomainfrom
test-upstream-fixes
Closed

Do not merge#280
maxdebayser wants to merge 17 commits intomainfrom
test-upstream-fixes

Conversation

@maxdebayser
Copy link
Copy Markdown
Collaborator

@maxdebayser maxdebayser commented Jul 3, 2025 •
edited
Loading

This is a PR to check if the combined upstream fix PRs will pass the tests @prashantgupta24

prashantgupta24 and others added 17 commits July 1, 2025 10:34
@prashantgupta24
🐛 req_ids is now a list
f7f6bb6 
Signed-off-by: Prashant Gupta <prashantgupta@us.ibm.com>
@prashantgupta24
🐛 req_ids is now a list
8f7acaf 
Signed-off-by: Prashant Gupta <prashantgupta@us.ibm.com>
@prashantgupta24
♻️ using cached requests
06b8d7d 
Signed-off-by: Prashant Gupta <prashantgupta@us.ibm.com>
@prashantgupta24
🐛 first pass for sb
a064d3b 
Signed-off-by: Prashant Gupta <prashantgupta@us.ibm.com>
@prashantgupta24
🐛 first pass for cb
989f6d2 
Signed-off-by: Prashant Gupta <prashantgupta@us.ibm.com>
@prashantgupta24
Merge remote-tracking branch 'upstream/main' into fix-upstream
1dcc582 
Signed-off-by: Prashant Gupta <prashantgupta@us.ibm.com>
@prashantgupta24
🐛 fix merge bug
bd7e008 
Signed-off-by: Prashant Gupta <prashantgupta@us.ibm.com>
@prashantgupta24
🎨 renaming vars
fe8e64c 
Signed-off-by: Prashant Gupta <prashantgupta@us.ibm.com>
@prashantgupta24
🔥 remove commented code
df9214b 
Signed-off-by: Prashant Gupta <prashantgupta@us.ibm.com>
@maxdebayser
Duplicate the SamplingMetadata class
c23f4c5 
We were previously reusing the GPU SamplingMetadata
class but there have been incompatible changes upstream
(PR vllm-project/vllm#16728)

Since it's not clear for now whether we want, should
or can reuse the LogitsProcessor implementation as is,
I'm making a copy of the old version of the class for
the spyre backend.

This won't affect any features for now since the vllm
change was an internal refactoring without UX impact.

Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
@prashantgupta24
🔥 remove extra commas
f065785 
Signed-off-by: Prashant Gupta <prashantgupta@us.ibm.com>
@maxdebayser
fix linting
425c3d2 
Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
@maxdebayser
Actually more classes need to be duplicated
05ea423 
Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
@maxdebayser
import the right sampler
6e1f712 
Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
@maxdebayser
fix tests
c614eb1 
Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
@maxdebayser
fix tests
a3b37c4 
Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
@maxdebayser
Merge branch 'fix_sampling_metadata' into test-upstream-fixes
6701206
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 3, 2025

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

@prashantgupta24
Copy link
Copy Markdown
Collaborator

prashantgupta24 commented Jul 7, 2025

I have another PR here to do the same, the tests pass there! #283

@prashantgupta24
Copy link
Copy Markdown
Collaborator

prashantgupta24 commented Jul 9, 2025

This is done

@maxdebayser maxdebayser deleted the test-upstream-fixes branch March 5, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rafvasq rafvasq Awaiting requested review from rafvasq rafvasq is a code owner

@prashantgupta24 prashantgupta24 Awaiting requested review from prashantgupta24 prashantgupta24 is a code owner

@sducouedic sducouedic Awaiting requested review from sducouedic sducouedic is a code owner

@yannicks1 yannicks1 Awaiting requested review from yannicks1 yannicks1 is a code owner

@tdoublep tdoublep Awaiting requested review from tdoublep tdoublep is a code owner

@nikolaospapandreou nikolaospapandreou Awaiting requested review from nikolaospapandreou nikolaospapandreou is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maxdebayser @prashantgupta24