Skip to content

feat: allow custom install commands on yarn-install #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2022

Conversation

rafael-anachoreta
Copy link
Contributor

@rafael-anachoreta rafael-anachoreta commented Sep 13, 2022

TDESKAPP-700

Description

Add the ability to run custom yarn install commands.

How to test

image

Development checks

  • Add changeset according to guidelines (if needed)
PR commands

List of available commands:

  • @toptal-anvil ping reviewers - Ping FX team for review

@rafael-anachoreta rafael-anachoreta requested a review from a team September 13, 2022 10:38
@rafael-anachoreta rafael-anachoreta self-assigned this Sep 13, 2022
@rafael-anachoreta rafael-anachoreta marked this pull request as draft September 13, 2022 10:38
@rafael-anachoreta rafael-anachoreta force-pushed the TDESKAPP-700-install-options branch from a94232f to 0d4cd34 Compare September 13, 2022 10:59
@rafael-anachoreta rafael-anachoreta marked this pull request as ready for review September 13, 2022 11:00
@github-actions github-actions bot added the contribution DO NOT ADD MANUALLY label Sep 13, 2022
@toptal-devbot
Copy link

Greetings from FX team, @rafael-anachoreta 👋

Thank you so much for contributing 🙇

We have got high priority ticket generated on our Kanban board so we will do our best to make your experience supreme!

What's next? We will collaborate using this workflow. For you this practically means making sure DONE criteria is met and responding promptly to code review comments 😉

🙏 please, help us improve, rate your contributing experience after merge

@denieler denieler self-assigned this Sep 13, 2022
@rafael-anachoreta
Copy link
Contributor Author

@toptal-anvil ping reviewers

Copy link
Contributor

@denieler denieler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

Copy link
Contributor

@ozgurkececioglu ozgurkececioglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@OndrejTuma OndrejTuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

@rafael-anachoreta rafael-anachoreta merged commit 125085d into master Sep 15, 2022
@rafael-anachoreta rafael-anachoreta deleted the TDESKAPP-700-install-options branch September 15, 2022 08:49
@github-actions github-actions bot mentioned this pull request Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution DO NOT ADD MANUALLY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants