Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add missing title #13

Merged
merged 2 commits into from
Jun 24, 2022
Merged

chore: add missing title #13

merged 2 commits into from
Jun 24, 2022

Conversation

LashaJini
Copy link
Contributor

@LashaJini LashaJini commented Jun 23, 2022 •
edited by OndrejTuma
Loading

[FX-NNNN]

Description

Describe the changes and motivations for the pull request, unless evident from the title.

How to test

  • FIXME: Add the steps describing how to verify your changes

Review

  • Ensure that new GH Action have a README.md file
  • Ensure that yarn documentation:generate was executed

@LashaJini LashaJini requested a review from a team June 23, 2022 15:23
OndrejTuma
OndrejTuma approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@OndrejTuma OndrejTuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I'm afraid this will need another changeset

@OndrejTuma OndrejTuma merged commit c8f5528 into master Jun 24, 2022
@OndrejTuma OndrejTuma deleted the add-missing-title branch June 24, 2022 08:37
@github-actions github-actions bot mentioned this pull request Jun 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OndrejTuma OndrejTuma OndrejTuma approved these changes

@separatio separatio separatio approved these changes

@TomasSlama TomasSlama TomasSlama approved these changes

@denieler denieler denieler approved these changes

Assignees
No one assigned
Labels
no-jira
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LashaJini @denieler @TomasSlama @separatio @OndrejTuma