Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace bypass strategy description with one that better describes behaviour #876

Conversation

RobNicholsGDS
Copy link
Contributor

The current description of the bypass strategy uses the phrase "simply silences index updates" to describe the bypass strategy. I think this is misleading as doing something silently doesn't mean that a process does not happen but rather that there is no output. If I select a process to happen silently, I would expect a normal behaviour but without anything being logged or output to the console.

I believe that the bypass strategy does more than simply suppress output. Instead it bypasses the index update on model save.

@konalegi
Copy link
Contributor

konalegi commented Apr 6, 2023

Thanks for improvement!

@konalegi konalegi merged commit 1e9a1e0 into toptal:master Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants