Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODEOWNERS file #849

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Add CODEOWNERS file #849

merged 1 commit into from
Jun 10, 2022

Conversation

Jakub-Kwak
Copy link
Contributor

@Jakub-Kwak Jakub-Kwak commented Jun 10, 2022

We need every workflow file to have a team owner.
The last person's team that was updating workflow file was assigned in this case.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the changelog if the new code introduces user-observable changes. See changelog entry format for details.

@Jakub-Kwak Jakub-Kwak self-assigned this Jun 10, 2022
@Jakub-Kwak Jakub-Kwak requested review from konalegi and a team June 10, 2022 12:54
konalegi
konalegi previously approved these changes Jun 10, 2022
@konalegi konalegi dismissed their stale review June 10, 2022 13:03

think if we can expose team name to the public

@Jakub-Kwak Jakub-Kwak merged commit 14afebd into master Jun 10, 2022
@Jakub-Kwak Jakub-Kwak deleted the add-codeowners branch June 10, 2022 13:26
cyucelen pushed a commit to cyucelen/chewy that referenced this pull request Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants