Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable CI checks for PRs #846

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Enable CI checks for PRs #846

merged 1 commit into from
Jun 3, 2022

Conversation

konalegi
Copy link
Contributor

@konalegi konalegi commented Jun 3, 2022 •
edited
Loading

Enable CI checks for PRs

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the changelog if the new code introduces user-observable changes. See changelog entry format for details.

@konalegi konalegi marked this pull request as ready for review June 3, 2022 08:54
@konalegi konalegi merged commit 639db8c into master Jun 3, 2022
@konalegi konalegi deleted the run-check-on-prs branch June 3, 2022 08:58
cyucelen pushed a commit to cyucelen/chewy that referenced this pull request Jan 28, 2023
@konalegi
Enable CI checks for PRs (toptal#846)
b586ae1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexVPopov AlexVPopov AlexVPopov approved these changes

@shurikp shurikp shurikp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@konalegi @shurikp @AlexVPopov