Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI reconfiguration #774

Merged
merged 77 commits into from
Mar 22, 2021
Merged

CI reconfiguration #774

merged 77 commits into from
Mar 22, 2021

Conversation

Vitalina-Vakulchyk
Copy link
Contributor

@Vitalina-Vakulchyk Vitalina-Vakulchyk commented Mar 18, 2021

Remove appraisal;
Utilize GitHub Actions matrix;
Migrate to GitHub Actions;

PR progress:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the changelog if the new code introduces user-observable changes. See changelog entry format for details.

@Vitalina-Vakulchyk
Copy link
Contributor Author

@rabotyaga Seems, to make check required for merging, it needs to correct 'branch protection rules' in Chewy Settings section. I have not access to this section
https://docs.github.com/en/github/administering-a-repository/managing-a-branch-protection-rule

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@rabotyaga rabotyaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🚀

@Vitalina-Vakulchyk Vitalina-Vakulchyk merged commit a1c0b5d into master Mar 22, 2021
@Vitalina-Vakulchyk Vitalina-Vakulchyk deleted the ci-reconfiguration branch March 22, 2021 12:18
cyucelen pushed a commit to cyucelen/chewy that referenced this pull request Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants