Remove legacy dsl #747
Merged
Remove legacy dsl #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Feb 3, 2021
AlfonsoUceda
approved these changes
Feb 3, 2021
rabotyaga
approved these changes
Feb 3, 2021
rabotyaga
pushed a commit
that referenced
this pull request
Feb 11, 2021
* Remove legacy dsl * Remove some fields * Update doc * Remove everything that is related to the ES2 or runtime version * Fix readme a bit * Fix rubocop offense * Update gemspec
rabotyaga
pushed a commit
that referenced
this pull request
Feb 11, 2021
cyucelen
pushed a commit
to cyucelen/chewy
that referenced
this pull request
Jan 28, 2023
* Add ES6 support: remove multiple types mappings support. add `include_type_name` parameter for ES 6.7-6.8 * Remove legacy DSL & ES2 support (toptal#747) * Add Chewy::MultiSearch Feature (toptal#751)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are not going to support legacy DSL for the ES 6.x it makes sense to drop it completely.