Don't set the js feature for getrandom

[dvdplm]

Libraries should avoid setting features that may or may not be required when used.

The getrandom docs put it better: "This feature should only be enabled for binary, test, or benchmark crates. Library crates should generally not enable this feature, leaving such a decision to users of their library. Also, libraries should not introduce their own js features just to enable getrandom’s js feature."

[Nashtare]

This is a required feature to enable no-std compilation.

[dvdplm]

This is a required feature to enable no-std compilation.

Nah. Being a library, the decision about being no-std or not is up to the code that uses it. As explained in the docs, an application compiled to wasm (as an example of a no-std use case), can add the feature.

In this specific case, the js feature assumes a Javascript context, which does not encompass all no-std cases.

[Nashtare]

The CI error for targeting wasm-32-unknown-unknown seems weirdly specific to this feature though. It's the same we encountered years ago when porting librustzcash to no-std for substrate.

[dvdplm]

seems weirdly specific to this feature though

You are correct (as always). I read through rust-lang/cargo#1197 and found this workaround. Do you like it better?

[Nashtare]

Yeah it's cleaner that way, thanks!