-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: okay-browser-daily #2585
fix: okay-browser-daily #2585
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a script that's just copied from okay webpage, without changes.
actors/okay-daily-v2/main.js
Outdated
country = Country.CZ, | ||
customTableName = null, | ||
type = ActorType.Full, | ||
forceApifyProxy = false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is new field on input.
@rarous pls merge 🙏 |
@valekjo Can you, please, make just one actor, that is the best solution and delete all others? I really don't like growing junk :) |
@rarous Ok, kept just one, named |
@valekjo can you please try to rebase on |
ff71fd6
to
c9d6c40
Compare
@rarous Should work now. |
Thank you ❤️ |
This PR updates
okay-browser-daily
Actor, so it can use product sitemaps instead of collections, and improves scraping on the detail page.It works, but is super slow, so there is also alternative and faster solution that
The emulation uses data from one additional endpoint, pre-fetched shopify config, and script copied form okay.
This is added as
okay-daily-v2
, needed to update yarn.lock for that.See comments in PR for more details.