-
Notifications
You must be signed in to change notification settings - Fork 15.8k
add vendor_boot patching for some odd devices #9238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The same method to detect this case has been used in tiann/KernelSU#2650 and KernelSU-Next/KernelSU-Next#541 (comment) |
|
Thank you for your contribution. I'll need further thinking to make sure if there are better ways to detect this scenario. |
Just a heads up, there is a motorola device which has a compatible ramdisk in vendor_boot as well as boot, the current check picks the boot partition for this device, but you still could remove one of the magiskboot unpacking steps to save time since both work for the device. As for the speed, I think its fine since it only takes less than a second from my testing. But it still is a bit messy so I'm looking forward to new ideas if you have them. Currently the devices which need this are the Pixel 6 family, some Pixel 7 devices (not sure), and about 10 to 15 Xiaomi Mediatek devices which have officially gotten an upgrade to Android 15; so it would be nice if this case is acknowledged |
|
No pixel device has this behavior, I think you might have made a mistake |
Pixel 6/6 Pro/6a, while I only have confirmed it with 6a. |
|
I checked this https://dl.google.com/dl/android/aosp/bluejay-ota-bp2a.250705.008.a1-14519571.zip |
That can be done and is being used here (KernelSU-Next/KernelSU-Next@512f845), I have tried an early release of it on my xiaomi device and it does work but I wasn't sure how stable it was. |
|
@topjohnwu heya, have you decided on it yet..? |
|
@ukriu my plan is to either I just haven't have time to look into it yet |
This fixes (or adds) #8835