Status code changes for /loadsearch endpoint (#1)

* server returns 204 on no result found, 500 on no search source registered * minor fix and update doc
topi314 · Oct 12, 2023 · 12561f7 · 12561f7
1 parent 9d88452
commit 12561f7
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -184,7 +184,7 @@ The endpoint returns a [search result](#search-result-object) JSON object
 
 </details>
 
-If no results are found the endpoint returns a http status code of `404`
+If no results are found the endpoint returns a http status code of `204 No Content`
 
 ### Text Object
 

diff --git a/main/src/main/java/com/github/topi314/lavasearch/SearchManager.java b/main/src/main/java/com/github/topi314/lavasearch/SearchManager.java
@@ -41,7 +41,10 @@ public void shutdown() {
 	}
 
 	@Nullable
-	public AudioSearchResult loadSearch(String query, Set<AudioSearchResult.Type> types) {
+	public AudioSearchResult loadSearch(String query, Set<AudioSearchResult.Type> types) throws IllegalStateException {
+		if (this.searchManagers.isEmpty()){
+			throw new IllegalStateException("No search source registered");
+		}
 		for (var sourceManager : this.searchManagers) {
 			var searchResults = sourceManager.loadSearch(query, types);
 			if (searchResults != null) {

diff --git a/plugin/src/main/java/com/github/topi314/lavasearch/plugin/AudioSearchRestHandler.kt b/plugin/src/main/java/com/github/topi314/lavasearch/plugin/AudioSearchRestHandler.kt
@@ -36,6 +36,6 @@ class AudioSearchRestHandler(
         val result = searchManager.loadSearch(query, finalTypes)
         return if (result != null) {
             ResponseEntity.ok(result.toSearchResult(playerManager, pluginInfoModifiers, searchResultInfoModifiers))
-        } else ResponseEntity.notFound().build()
+        } else ResponseEntity.noContent().build()
     }
 }