PS-469 - update query for user payment reconciliation #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| }[] = []; | ||
|
|
||
| if (userIds.length > 0) { | ||
| const ids = uniq(userIds); |
There was a problem hiding this comment.
[correctness]
The use of uniq to filter userIds is a good practice to avoid redundant database queries. However, ensure that uniq is imported from a reliable library like lodash to prevent potential runtime errors.
| >` | ||
| >` | ||
| WITH u(user_id) AS ( | ||
| VALUES ${Prisma.join(ids.map((id) => Prisma.sql`(${id})`))} |
There was a problem hiding this comment.
[❗❗ security]
Using Prisma.sql to safely interpolate values into the SQL query is a good practice for preventing SQL injection. However, ensure that ids is properly sanitized and validated before this step.
| LEFT JOIN user_tax_form_associations utx ON upm.user_id = utx.user_id AND utx.tax_form_status = 'ACTIVE' | ||
| LEFT JOIN user_identity_verification_associations uiv ON upm.user_id = uiv.user_id | ||
| WHERE upm.user_id IN (${Prisma.join(uniq(userIds))}) | ||
| FROM u |
There was a problem hiding this comment.
[❗❗ correctness]
The alias u for the table is not defined in the FROM clause. Ensure that u is a valid alias for a table or subquery. This could lead to a runtime error if u is not properly defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.