Skip to content

[PROD RELEASE V6] #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkartunov merged 2 commits into from
Nov 2, 2025
Merged

[PROD RELEASE V6] #122

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb195d4
Fix challenge fetch
vas3a Oct 29, 2025
681710c
Merge pull request #120 from topcoder-platform/fix-challenge-fetch
kkartunov Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/api/challenges/challenges.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
orderBy,
uniqBy,
} from 'lodash';
import { ConflictException, Injectable } from '@nestjs/common';
import { BadRequestException, ConflictException, Injectable } from '@nestjs/common';
import { isUUID } from 'class-validator';
import { ENV_CONFIG } from 'src/config';
import { Logger } from 'src/shared/global';
Expand Down Expand Up @@ -66,9 +66,7 @@ export class ChallengesService {
throw new BadRequestException('Invalid challengeId provided! Uuid expected!');
}

// Use the URL constructor to avoid path traversal/SSRF risks.
const baseUrl = TC_API_BASE.endsWith('/') ? TC_API_BASE.slice(0, -1) : TC_API_BASE;
const requestUrl = new URL(`/challenges/${challengeId}`, baseUrl).toString();
const requestUrl = `${TC_API_BASE}/challenges/${challengeId}`;
Copy link

@github-actions github-actions bot Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[❗❗ security]
The change from using the URL constructor to string concatenation for requestUrl reintroduces potential security risks such as path traversal or SSRF (Server-Side Request Forgery). Using the URL constructor helps mitigate these risks by ensuring proper URL parsing and construction. Consider reverting to the previous implementation using the URL constructor.


try {
const challenge = await this.m2MService.m2mFetch<Challenge>(requestUrl);
Expand Down
Loading