Skip to content

thread-focus-mode.spec.ts: anchor-preservation test assumes a session-wide invariant the feature doesn't guarantee #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ALLiDoizCode merged 2 commits into from
Aug 3, 2026
Merged

thread-focus-mode.spec.ts: anchor-preservation test assumes a session-wide invariant the feature doesn't guarantee #65

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ca78b5
RALPH: fix(desktop): re-capture anchor before second toggle in thread…
ALLiDoizCode Aug 3, 2026
bad1312
refactor(desktop): name focus-mode spec anchors by which toggle they …
ALLiDoizCode Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions desktop/tests/e2e/thread-focus-mode.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ test("focus and split preserve reading context and interaction ownership", async
element.scrollTop = element.scrollHeight * 0.4;
element.dispatchEvent(new Event("scroll", { bubbles: true }));
});
const anchorId = await topVisibleMessageId(body);
const anchorIdBeforeFocusToggle = await topVisibleMessageId(body);

const focusModeToggle = page.getByRole("button", {
name: "Show thread beside channel",
Expand All @@ -202,10 +202,10 @@ test("focus and split preserve reading context and interaction ownership", async
await expect(page.getByTestId("message-thread-body")).toBeFocused();
await expect(summary).not.toBeFocused();
await expect(
body.locator(`[data-message-id="${anchorId}"]`),
body.locator(`[data-message-id="${anchorIdBeforeFocusToggle}"]`),
).toBeInViewport();
await expect(
body.locator(`[data-message-id="${anchorId}"]`),
body.locator(`[data-message-id="${anchorIdBeforeFocusToggle}"]`),
).not.toHaveAttribute("data-highlighted", "true");

// Sidebar background dismissal belongs to the overlay presentation only.
Expand All @@ -214,14 +214,18 @@ test("focus and split preserve reading context and interaction ownership", async
.evaluate((element) => (element as HTMLElement).click());
await expect(page.getByTestId("message-thread-panel")).toBeVisible();

// The sidebar click above is free to move scroll position, so re-capture
// the anchor fresh rather than reusing anchorIdBeforeFocusToggle.
const anchorIdBeforeSplitToggle = await topVisibleMessageId(body);

const splitModeToggle = page.getByRole("button", { name: "Expand thread" });
await splitModeToggle.focus();
await splitModeToggle.press("Enter");
await expect(drawer).toBeVisible();
await expect(channel).toHaveAttribute("inert", "");
await expect(page.getByTestId("thread-view-mode-toggle")).toBeFocused();
await expect(
body.locator(`[data-message-id="${anchorId}"]`),
body.locator(`[data-message-id="${anchorIdBeforeSplitToggle}"]`),
).toBeInViewport();

// Focus mode owns Escape even while the rich-text composer and one of its
Expand Down
Loading