Build and push quarry image #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A github action to build and push the quarry container image to quay.io. Bug: T316958
siddharthvp
reviewed
Oct 13, 2023
Comment on lines
13
to
21
| with: | ||
| repository: ${{ github.event.pull_request.head.repo.full_name }} | ||
|
|
||
| - name: git fetch | ||
| run: | | ||
| git fetch | ||
| - name: git checkout | ||
| run: | | ||
| git checkout ${{ github.head_ref }} |
There was a problem hiding this comment.
no need to do any of this - just uses: actions/checkout@v4 is enough for it to check out the branch from the PR.
There was a problem hiding this comment.
Neat! Does this work with an outside contributor off of a fork? I guess we can merge it and find out.
There was a problem hiding this comment.
The checkout would work (i.e. the fork gets checked out). What won't work is accessing the github secrets for docker login.
siddharthvp
reviewed
Oct 16, 2023
siddharthvp
previously approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A github action to build and push the quarry container image to quay.io.
The way the code is structured in the repo has a downside, in that any update to the code will update the container image. It is likely worth moving the code off of the root of the repo into /code/ or the like, then this action can be updated to only trigger when there is a change to something in that directory. Though this will likely cause a lot of busy work until quarry moves to k8s in prod.
For now it updates the image all the time, not the biggest problem, but not the most elegant.
Bug: T316958