Repository navigation
feat(promachos): port persona home and bubble chats to v2 - #187
Conversation
|
What: Independent review passed on the exact PR head. Reviewer verdict relayed unchanged: Verdict: PASS for exact head The recorded focused tests, launch tests, four typechecks, lint, inventory, and diff check all pass; I reviewed their logs without rerunning them. Integrated UI and live-provider proof remain deferred to the planner as agreed. Elon record
|
Agent work on this PREstimated cost unknown · 0 responses · 50 sessions · 8.4 h wall time
Flags: 4 human corrections · 96 large tool outputs · 118 repeated commands · 11 repeated failures · 120 repeated reads · 17 repeated skill loads · 49 sessions with usage bound to no task · 1 session without usage records Details: snapshot, prices, coverage, counters
Token counters by model (native counter semantics; never added across semantics): Selected rates (USD per million tokens). These rates value the report at the selected schedule date; they do not establish historical prices or subscription spending.
Other output and reasoning are priced without double counting inclusive native output. Missing rates remain unknown. Local measurement from native records; usage totals are not billing. Updated in place by |
|
What: Independent review passed on the metadata-only successor head. Reviewer verdict relayed unchanged: PASS for exact head The Coordinator Elon record: |
b837d5d to
1c9b37f
Compare
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: unavailable · PR result: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
|
What: Independent source review passed for the exact current #175 head. Reviewer findings and verdict, relayed unchanged from the visible T3 reviewer: Confirmed. PASS for exact head I inspected the final receipts: three-file lint and web/server typechecks exit 0, four home tests pass, and the launch suite passed on identical launch code and runtime inputs. Inventory, clean worktree, diff check, and base ancestry are confirmed; the integrated UI and live-provider proof remain deferred as agreed. Review identity: visible T3 thread Requirements and who asked: User requires independent exact-head source review on the merged #183/#172 base. |
ce3aede to
8407456
Compare
|
What: Independent exact-head review requests changes on8407456 for missing kit on partial launch retry. Reviewer findings relayed unchanged: Request changes:
|
|
What: Independent exact-head review passes the approved partial-launch retry fix. Reviewer verdict and findings relayed unchanged: PASS:
|
5315c2a to
927c797
Compare
|
What: Independent exact-head review passes the CI-only base successor927. Reviewer verdict and findings relayed unchanged: PASS for The worktree is clean and local and remote heads match. The base adds only the two workflow lines; all 38 PR file blobs match reviewed head READ-ONLY independent reviewer: visible Prism-routed GPT-6-Luna/Codex T3 thread Requirements and who asked: Root requires samePR187 routine base maintenance, exact blob/range-diff reuse and exact-current-head independent status. |
927c797 to
73435be
Compare
|
What: Independent exact-head review passes the merged recovery-history base successor734. Reviewer verdict and findings relayed unchanged: PASS for The new continuation marker is inert for Promachos’s ordinary initial dispatch: it supplies neither source ID, so the run fields are empty and recovery admission returns null. Projection storage preserves the marker only when a run already has one; Prism and ThreadLaunch APIs are unchanged across the base update. No new findings; CI is still running, and the approved UI/live-provider deferral remains. READ-ONLY reviewer: visible Prism-routed GPT-6-Luna/Codex T3 thread Requirements and who asked: Root requires current734/base4c rebase, affected proof and exact-head independent review on samePR187. |
* wip: checkpoint independent Promachos v2 home and view port * feat(promachos): port home and chat onto v2 launch * fix(promachos): retain projected provider error notices * wip: validate Promachos launch and isolate fork hooks * fix(promachos): register authorization test ownership * fix(promachos): keep module-local helpers private * fix(promachos): restore launch kit after partial create retry
What: Promachos mode brings persona-home chats and bubbles to V2.
Why: The V1 launch hook and timeline filter depended on APIs and row types removed upstream.
So what: The #175-only successor passes affected proof, exact-head review and CI on the latest authorized base; the planner owns the explicitly deferred integrated UI/live-provider pass and merge/cutover.
Closes #175. Authorized by #166 and the planner’s final delivery instruction. Contribution to the Objective: Promachos chats in bubbles with his persona loaded from his home.
Home creation uses ProjectService and preserves existing persona files. Initial conversation sends use upstream launchThread and #169’s shared Prism service, selecting the configured model and launch-time D5′ kit once. Prism’s shared validator checks both authoritative registries before thread creation and falls through an unavailable candidate. Accepted receipt retries preserve the stored selection and message.
The view retains HTML/MCP-app outputs and provider-error/usage-limit notices, collapses technical work and reasoning, and keeps upstream queued-message controls. Paragraph bubbles use the real Markdown parser; inline question/approval cards retain composer handlers. Homes remain environment-scoped, native people/child lineage filtering is preserved, and switching back restores saved multiple-model choices.
Base:
4c2b38436fda0fef5bb2b101d52f90d7ed831df0(#183, #172, #188 Wight, #190 ACP fix, #191 CI setup and #192 recovery history merged). Head:73435bedda993ddc954347ce79072caad93ba1c9. Range-diff confirms only seven #175 commits remain (four port commits, metadata registration, module-local export corrections and the partial-launch retry fix); #172 append-only metadata was retained in full; mechanical rebase conflicts retained the complete merged feature-map/allowlist entries plus #175. No #169 predecessor implementation delta remains.Focused proof on
73435bedda993ddc954347ce79072caad93ba1c9, merged base4c2b38436f. Supported Node24.13.1, host-neutral environment, serial batches with immediate uptime1m<8 admission and #169 priority:node scripts/fork-features.mjs check: 21 features pass, exit0;git diff --check: pass. Retained commands, proof identity and results are on Port Promachos mode #175; temporary logs have explicit exit codes.UI evidence is explicitly deferred by the user to the planner’s integrated pass. No browser, desktop build, screenshot/video, live provider execution or live userdata mutation was performed. The receipt harness disables provider execution; focused checks do not claim repo-wide coverage. No version bump, main push, merge, install or deployment.
MODULAR audit: fork behavior, RPC/error mapping, model/fanout policy, scroll policy and launch cases live in Promachos modules. Upstream carries imports, optional fields, registrations and calls; no upstream implementation is copied. Feature-map primary ownership and allowlist retained.
apps/server/src/auth/RpcAuthorization.test.tsapps/server/src/observability/RpcInstrumentation.tsapps/server/src/orchestration-v2/ThreadLaunchService.test.tsapps/server/src/ws.tsapps/web/src/components/AppSidebarLayout.tsxapps/web/src/components/ChatView.tsxapps/web/src/components/chat/ChatComposer.tsxapps/web/src/components/chat/MessagesTimeline.tsxapps/web/src/components/sidebar/SidebarChrome.tsxdocs/README.mdpackages/client-runtime/src/operations/commands.test.tspackages/client-runtime/src/operations/commands.tspackages/contracts/src/clientRpcPermissions.tspackages/contracts/src/index.tspackages/contracts/src/orchestrationV2.tspackages/contracts/src/rpc.tsHunks over approximately 15 lines occur only in MessagesTimeline:
All other upstream hunks are at most15 lines including context. Whole-file counts accumulate distributed hooks. The launch test registration is four lines; all new behavior assertions live in the fork module.
Requirements and who asked: User, #175/#166 and planner approvals require persona home, V2 bubbles/rows, upstream launchThread, shared Prism validator, preserved visible results/notices/queue controls, and one PR into fork/v2.
Deleted: Obsolete V1 start API and technical/reasoning presentation; no dependency repair, duplicate model eligibility code or persisted routing state added.
Bottleneck: Planner-owned integrated UI/live-provider proof remains explicitly deferred; no source, dependency or CI blocker remains.
Checked myself: Inspected the complete port and real V2 error projection/renderers, verified merged refs and #175-only range, ran focused receipt/parser/home tests and scoped checks.
Website impact: none, this port changes the application and its user guide without marketing routes or public website content. Upstream search found no Promachos implementation in upstream/main or matching Issues/PRs; the prior search record is on #175.
Model/harness: GPT-6.1-Sol through Codex in T3 Code; independent reviewer routed by Prism through the visible T3 reviewer role. Durable task record: #175 (comment).
Latest authorized base maintenance: #192 recovery history is merged at4c. Inspection confirms normal Promachos initial-message commands have neither forkPrismRetryOfRunId nor usageLimitContinuationOfRunId, so the new continuation source/admission hooks return empty/null; ProjectionStore preserves a recorded source only if present. Prism.resolve, shared validator and upstream launch API are unchanged. Rebase retains all seven #175 commits with no conflicts; only feature-map and orchestrationV2 whole-file blobs incorporate merged-base changes, other36 PR blobs are identical. No #192 repair is composed. Five launch cases and server/contracts typechecks freshly pass against changed common runtime/schema inputs; unchanged scoped lint and independent source proof are reused. Exact734 independent review PASS, findings #187 (comment); newest review/independent is success by lukemaj on734, linked to these PR findings. Current-head CI SUCCESS, including aggregate Check, all six server shards, web tests, Lint, Typecheck, Build, release smoke and Fork Stack Model. Configured EAS/preview/mobile jobs are skipped; no failed check is waived.
Approved consequential decision A, implemented: when creation has an accepted receipt but the initial message does not, call existing Prism.resolve with the stored model as explicit selection to rebuild the current launch-time kit. No validation, fallback, reroute, model change or new durable state. Accepted initial-message retries remain receipt-only. The planner expressly accepts settings as of the first submitted/accepted message; immutable first-preparation kit storage (B) was not selected.
The real SQL/receipt regression was red before recovery (persisted
Hellowithout persona), then green after it. It commits real creation, verifies accepted create/absent message receipt, changes kit and model preferences, asserts current kit with the unchanged stored model, then changes kit again and verifies accepted replay retains exactly one message/run. All five launch cases pass. An exact-optional test fixture type error was corrected by omitting the absent field, without weakening the oracle. The original independent finding is recorded at #187 (comment); the source-identical5315 PASS resolves the finding; prior927 metadata/base review passed; current734 review also passes.The prior Test Server4 failure was a worker PID collision in inherited ACP fixture logic, repaired separately by merged #190. No ACP source or tests are included in the #175 diff. Six original #175 patches are preserved, with one owned retry-fix commit added; rebase conflicts only retained both additive Wight/Promachos exports and complete append-only feature-map/allowlist groups. No dependency repair was composed.
Historical #175 CI corrections: register the existing authorization test under its primary feature owner/allowlist, and remove three unused module-local exports without changing bodies/callers. No policy or behavior change.
Required Agent Observer report republished for this successor, exit0: #187 (comment). Publication succeeded; native usage attribution is incomplete and estimated cost remains unknown, not zero.