(via tonythethompson): Use submitted recipe from useOliveStream in completion effect instead of

[macroscopeapp]

Summary

This PR fixes the completion effect in ExecutionWorkspace.tsx to use the actual submitted recipe from useOliveStream instead of rebuilding it from component state.

Changes

• useOliveStream hook: Added runRecipeJson to the return object, exposing runRecipeJsonRef.current which contains the recipe that was actually submitted for execution.

• ExecutionWorkspace.tsx: Updated the completion effect to consume runRecipeJson from the hook rather than reconstructing the recipe from state. Updated the dependency array to use runRecipeJson instead of state.

Motivation

Using the submitted recipe directly ensures consistency between what was executed and what is used in the completion effect. Rebuilding from state could potentially introduce inconsistencies if the state changed between submission and completion.

Note

Macroscope: Fix It For Me

• This PR originated from this comment in Enhance model selection UI and integrate Playground output #262.
• Since auto-merge is on, Macroscope will merge this PR after waiting for checks to pass.
• If you'd rather not wait, you can always merge this yourself but no further action from you is currently needed.
• You can also @mention Macroscope in this PR to request further changes.

Activity

Currently: Merged by tonythethompson

Previously

• Not merged: conflicts
• Waiting on checks
• Pushed 8cd6091
• Action failed: CI
• Waiting on checks
• Pushed dae8f00
• Working on next commit...
• Waiting on checks
• Pushed a5e300a

---

Note

Use runRecipeJson state from useOliveStream to capture submitted recipe on completion

• useOliveStream now exposes runRecipeJson as a state value (alongside the existing ref), resetting it on new run epochs and setting it when a run is initiated.
• ExecutionWorkspace replaces its dependency on runRecipeJsonRef with the new runRecipeJson state in the completion effect that writes to the Playground store via setCapturedRunRecipe.
• mapExecutionProviderFromRecipe in oliveRecipeHub.ts is extended to accept a JSON string directly, returning undefined on parse failure; isWebGpuRecipe in PlaygroundPanel is simplified to use this updated signature.

^{Macroscope summarized 72597ad.}

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
olive-studio	Ready	Preview	Aug 13, 2026 5:05am

[sourcery-ai]

Hey - I've left some high level feedback:

• Consider resetting runRecipeJsonRef to null on new executions so the completion effect always captures the recipe from the most recent run and doesn’t accidentally reuse an older value.
• If setCapturedRunRecipe or downstream consumers expect a structured recipe object rather than a JSON string, it may be clearer for useOliveStream to expose runRecipeJson as a parsed object to avoid mixed types and repeated parsing.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider resetting `runRecipeJsonRef` to `null` on new executions so the completion effect always captures the recipe from the most recent run and doesn’t accidentally reuse an older value.
- If `setCapturedRunRecipe` or downstream consumers expect a structured recipe object rather than a JSON string, it may be clearer for `useOliveStream` to expose `runRecipeJson` as a parsed object to avoid mixed types and repeated parsing.

Fix all in Cursor

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[greptile-apps]

Greptile Summary

The PR now carries the exact submitted recipe through React state and uses it when a completed execution is captured for Playground.

• Adds runRecipeJson to the useOliveStream return contract while retaining the internal recipe ref.
• Updates the completion effect to consume the state-backed submitted recipe.
• Extends execution-provider detection to accept either parsed recipes or JSON strings.
• Adds coverage for object, JSON-string, and invalid-recipe provider detection.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains; the hook return contract is coherent and the conflict markers previously breaking compilation are absent from the current code.

Important Files Changed

Filename	Overview
src/components/features/execute/ExecutionWorkspace.tsx	Uses the state-backed submitted recipe in the completion effect; the prior conflict markers and hook-property mismatch are resolved.
src/components/features/execute/useOliveStream.ts	Exposes and maintains submitted recipe state consistently with the hook interface and current consumer.
src/components/features/playground/PlaygroundPanel.tsx	Delegates JSON parsing and WebGPU provider detection to the shared recipe helper without changing invalid-input behavior.
src/lib/oliveRecipeHub.ts	Safely accepts JSON strings in provider detection while preserving existing structured-object handling.
src/lib/tests/oliveRecipeHub.deriveUiState.test.ts	Adds focused coverage for structured recipes, JSON strings, malformed JSON, and missing systems.

_{Reviews (11): Last reviewed commit: "perf: memoize captured WebGPU recipe che..." | Re-trigger Greptile}

Dismissed because a newer commit was pushed; Greptile will re-review the current head.

[macroscopeapp]

🟠 High execute/BatchProcessingPanel.tsx:300

A queued local-source job with no uploaded workspace files is marked failed with “No model selected” and never runs. getPipelineValidation recognizes local models only when localFiles.length > 0, so removing the synthetic entry here makes job.modelIdentifier invisible to validation; restore that entry or validate the job identifier directly.

-    localFiles: state.localFiles,
+    localFiles:
+      job.modelSource === "local" && state.localFiles.length === 0
+        ? [{ name: job.modelIdentifier, size: 0 }]
+        : state.localFiles,

🚀 Reply "fix it for me" or copy this AI Prompt for your agent:

In file @src/components/features/execute/BatchProcessingPanel.tsx around line 300:

A queued local-source job with no uploaded workspace files is marked failed with “No model selected” and never runs. `getPipelineValidation` recognizes local models only when `localFiles.length > 0`, so removing the synthetic entry here makes `job.modelIdentifier` invisible to validation; restore that entry or validate the job identifier directly.

Dismissed because a newer commit was pushed; Greptile will re-review the current head.

[Copilot]

Pull request overview

This PR aims to make ExecutionWorkspace use the exact recipe JSON that was submitted for an Olive run (captured by useOliveStream) when handling run completion, instead of rebuilding the recipe from potentially-changed component state.

Changes:

• Extends useOliveStream’s public return shape to expose the submitted run recipe JSON.
• Updates ExecutionWorkspace’s completion useEffect to consume that submitted recipe.
• Adjusts the completion effect dependencies to avoid ref-related hooks lint issues.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/components/features/execute/useOliveStream.ts	Adds runRecipeJson to the hook return contract, but currently returns a broken object shape (duplicate keys / missing field).
src/components/features/execute/ExecutionWorkspace.tsx	Switches completion handling toward using the submitted recipe, but currently contains unresolved merge conflict markers and inconsistent destructuring.

Suppressed comments (1)

src/components/features/execute/ExecutionWorkspace.tsx:592

• Unresolved merge conflict markers in this useEffect will break JSX/TS parsing. Resolve the conflict and keep a single dependency array; using runRecipeJson (returned value) avoids any ref/deps confusion and matches the PR’s intent.

  }, [executionStatus, setCapturedRunRecipe, runRecipeJsonRef]);

  // Auto-save completed diagnoses to history
  const prevDiagnosticRef = useRef(mcpDiagnostic);
  useEffect(() => {

---

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Dismissed because a newer commit was pushed; Greptile will re-review the current head.

Dismissed because a newer commit was pushed; Greptile will re-review the current head.

Dismissed because a newer commit was pushed; Greptile will re-review the current head.

[linear-code]

OLI-97