audit: fix 12 code-quality issues, extract 4 large components, lint-clean sweep

olive-mcp-server/olive_mcp_server/tools/docs_search.py

@@ -79,7 +79,8 @@ def _load_kb_text() -> list[tuple[str, str]]:
                 data = json.load(f)
             for path, text in _flatten(data, prefix=file.stem):
                 all_text.append((path, text))
-        except Exception:
+        except (OSError, UnicodeDecodeError, json.JSONDecodeError) as exc:
+            logger.debug("Failed to load KB file %s: %s", file.name, exc)
             continue
     return all_text
 

olive-mcp-server/olive_mcp_server/tools/strategy_advisor.py

@@ -51,12 +51,12 @@ def _normalize_model_type(model_type: str) -> str:
 
 
 def _latency_rank(latency: str) -> int:
-    l = latency.lower()
-    if "<100" in l or "100ms" in l or "realtime" in l or "real-time" in l:
+    lat_lower = latency.lower()
+    if "<100" in lat_lower or "100ms" in lat_lower or "realtime" in lat_lower or "real-time" in lat_lower:
         return 0
-    if "<500" in l or "500ms" in l:
+    if "<500" in lat_lower or "500ms" in lat_lower:
         return 1
-    if "<1" in l and "s" in l:
+    if "<1" in lat_lower and "s" in lat_lower:
         return 2
     return 3
 

olive-mcp-server/tests/test_docs_search_semantic.py

@@ -315,3 +315,21 @@ def fake_build(texts):
     docs_search._get_live_index()
     assert docs_search._LIVE_EMBED_CACHE_TIME == 200.0
     assert docs_search._LIVE_SNIPPETS[0][1] == "newer content"
+
+
+def test_load_kb_text_skips_invalid_utf8_and_keeps_valid_files(
+    tmp_path, monkeypatch: pytest.MonkeyPatch
+):
+    """One undecodable KB file must not abort loading of sibling valid JSON."""
+    bad = tmp_path / "bad_utf8.json"
+    good = tmp_path / "good.json"
+    bad.write_bytes(b'{"oops": "\xff\xfe invalid"}')
+    good.write_text('{"pass": "OnnxQuantization works"}', encoding="utf-8")
+
+    monkeypatch.setattr(docs_search, "KB_DIR", tmp_path)
+    loaded = docs_search._load_kb_text()
+    sources = " ".join(path for path, _ in loaded)
+    snippets = " ".join(text for _, text in loaded)
+    assert "good" in sources
+    assert "OnnxQuantization" in snippets
+    assert "bad_utf8" not in sources

src/components/TitleBar.tsx

@@ -13,6 +13,7 @@ export function TitleBar() {
 
   useEffect(() => {
     const tauri = typeof window !== "undefined" && ("__TAURI_INTERNALS__" in window || "__TAURI__" in window);
+    // eslint-disable-next-line react-hooks/set-state-in-effect
     setIsTauri(Boolean(tauri));
     if (!tauri) return;
 

src/components/features/ArenaConvenience.tsx

@@ -71,6 +71,7 @@ export function FromOliveOutputs({ slotLabel, onFile }: FromOliveOutputsProps) {
     // Do not auto-retry after a failed list: error + null payload would re-fire
     // forever. Refresh list (or re-open after clearing) is the recovery path.
     if (open && !payload && !loading && !error) {
+      // eslint-disable-next-line react-hooks/set-state-in-effect
       void loadList();
     }
   }, [open, payload, loading, error, loadList]);