New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix install command to import Trix JS module and stop publishing the CSS file in favor of the styles component #45

Merged

tonysm merged 3 commits into main from tm/fix-install-script

Mar 2, 2024

Owner

tonysm commented Mar 1, 2024 •

edited

Loading

Changed

The install command now should correctly import the Trix JS module by appending it to one of the entrypoint modules (either resources/js/index.js or resources/js/app.js)
Remove the CSS file being published, we are now favoring the Trix styles component
Adds the same tweaks ActionText does for the custom element when using image attachments with sgdis to the end of the styles component

closes #43
closes #44

tonysm and others added 3 commits

March 1, 2024 19:48


          Fix installation command not importing the trix module correctly and …

c3c8828

…remove the CSS file (we use the component now)


          Fix styling

83380e4


          Add a new line after the trix import

fc72f24

tonysm merged commit 3782fbd into main

13 checks passed

tonysm deleted the tm/fix-install-script branch

March 2, 2024 00:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet