Skip to content

Transitives on by default resolves #10 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tonycknight merged 2 commits into from
Jan 1, 2024
Merged

Transitives on by default resolves #10 #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f72a9dc
make transitive scans the default
tonycknight Jan 1, 2024
13afb9c
update tests' args
tonycknight Jan 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/pkgchk-cli/Commands.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,17 @@ type PackageCheckCommandSettings() =

[<CommandArgument(0, "[SOLUTION|PROJECT]")>]
[<Description("The solution or project file to check.")>]
[<DefaultValue("")>]
member val ProjectPath = "" with get, set

[<CommandOption("-t|--transitives")>]
[<Description("Check transitive packages as well as top level packages.")>]
member val IncludeTransitives = false with get, set
[<Description("Toggle transitive package checks. -t false to exclude transtiives, -t true to include them.")>]
[<DefaultValue(true)>]
member val IncludeTransitives = true with get, set

[<CommandOption("-o|--output")>]
[<Description("Output directory for reports.")>]
[<DefaultValue("")>]
member val OutputDirectory = "" with get, set

[<ExcludeFromCodeCoverage>]
Expand Down
2 changes: 1 addition & 1 deletion tests/pkgchk-cli.tests/IntegrationTests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ module IntegrationTests =
sprintf "dotnet add ./%s/testproj.csproj package %s -v 4.3.1" outDir regexPackage

let runPkgChkArgs outDir =
sprintf "dotnet pkgchk-cli.dll ./%s/testproj.csproj -t" outDir
sprintf "dotnet pkgchk-cli.dll ./%s/testproj.csproj -t true" outDir

let createProc cmd =
let (exec, args) = cmdArgs cmd
Expand Down