A few important updates to variable font upgrades#737
Merged
tonsky merged 3 commits intotonsky:masterfrom Apr 4, 2019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shortly after #735 was merged, I found a couple of important errors that needed correction.
Important updates:
/Lha-cyhad a fixed outline, but was non-compatible for interpolation, which prevented the variable font from building. I've resolved this.weightClassinstead ofAxis Locationin masters.distr/otf&distr/woff2as well asdistr/ttf&distr/variable_ttfWhat's left out of the update:
distr/eot&distr/woffare still the old versions – as far as I know, these are only applicable to IE6–11, so I'm not sure whether they should still be in the distributed fonts anymore, at all. If you think they're still useful, @tonsky, could you please add them from the updated source? If not, I suggest removing these fonts, as they will have slight inconsistencies with the updated versions.