Bold weight has greater line height; causes glitches in Xcode editor #252
Milestone
Comments
|
This also happens in Fira Mono (see mozilla/Fira#168). |
|
Should be fixed in v2 |
Losangelosgenetics
pushed a commit
to Losangelosgenetics/FiraCode
that referenced
this issue
Mar 12, 2020
200: Update rake requirement from ~> 10.0 to ~> 12.3 r=bronzdoc a=dependabot[bot] Updates the requirements on [rake](https://github.com/ruby/rake) to permit the latest version. <details> <summary>Changelog</summary> *Sourced from [rake's changelog](https://github.com/ruby/rake/blob/master/History.rdoc).* > === 12.3.1 > > ==== Bug fixes > > * Support did_you_mean >= v1.2.0 which has a breaking change on formatters. > Pull request [tonsky#262](https://github-redirect.dependabot.com/ruby/rake/issues/262) by FUJI Goro. > > ==== Enhancements: > > * Don't run task if it depends on already invoked but failed task. > Pull request [tonsky#252](https://github-redirect.dependabot.com/ruby/rake/issues/252) by Gonzalo Rodriguez. > * Make space trimming consistent for all task arguments. > Pull request [tonsky#259](https://github-redirect.dependabot.com/ruby/rake/issues/259) by Gonzalo Rodriguez. > * Removes duplicated inclusion of Rake::DSL in tests. > Pull request [tonsky#254](https://github-redirect.dependabot.com/ruby/rake/issues/254) by Gonzalo Rodriguez. > * Re-raise a LoadError that didn't come from require in the test loader. > Pull request [tonsky#250](https://github-redirect.dependabot.com/ruby/rake/issues/250) by Dylan Thacker-Smith. > > === 12.3.0 > > ==== Compatibility Changes > > * Bump `required_ruby_version` to Ruby 2.0.0. Rake has already > removed support for Ruby 1.9.x. > > ==== Enhancements: > > * Support `test-bundled-gems` task on ruby core. > > === 12.2.1 > > ==== Bug fixes > > * Fixed to break Capistrano::Application on capistrano3. > > === 12.2.0 > > ==== Enhancements: > > * Make rake easier to use as a library > Pull request [tonsky#211](https://github-redirect.dependabot.com/ruby/rake/issues/211) by [**drbrain**](https://github.com/drbrain) > * Fix quadratic performance in FileTask#out_of_date? > Pull request [tonsky#224](https://github-redirect.dependabot.com/ruby/rake/issues/224) by [**doudou**](https://github.com/doudou) > * Clarify output when printing nested exception traces > Pull request [tonsky#232](https://github-redirect.dependabot.com/ruby/rake/issues/232) by [**urbanautomaton**](https://github.com/urbanautomaton) > > ==== Bug fixes > > * Account for a file that match 2 or more patterns. > Pull request [tonsky#231](https://github-redirect.dependabot.com/ruby/rake/issues/231) by [**styd**](https://github.com/styd) ></table> ... (truncated) </details> <details> <summary>Commits</summary> - See full diff in [compare view](https://github.com/ruby/rake/commits/v12.3.1) </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. --- **Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit. You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com). <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) Finally, you can contact us by mentioning @dependabot. </details> Co-authored-by: dependabot[bot] <[email protected]>
Losangelosgenetics
pushed a commit
to Losangelosgenetics/FiraCode
that referenced
this issue
Mar 12, 2020
253: Add config to ignore Gemfile source r=bronzdoc a=ericzpd This PR adds `:ignore_gemfile_source` config to ignore source specified in Gemfile and always use `:rubygems_url` as gems upstream. Valid config values: `true` or `false`. This change allows Gemstash to use a Bundler mirror site for fetching remote gems, instead of fetching from Gemfile source. Related Issue: tonsky#252 Co-authored-by: Zheng Piaodan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For some reason the bold weight has a slightly higher line height (maybe it's the leading?) than the other weights. See screenshot (the app is plain old TextEdit on Mac OS X.)
In editors that take this into account (such as Xcode), this results in uneven linespacing if some syntax styles use bold. Worse, I suspect this is triggering the already-reported scrolling glitch in Xcode 8 (#241) — as you type, when Xcode is updating the syntax coloring of text up above in the file, it can also be changing its line height, causing text below to move up or down.
Unfortunately there's no way I know of to tell Xcode to use fixed linespacing. The only workaround is to avoid the bold weight, which is a shame because it's great for keywords and doc-comments.
The text was updated successfully, but these errors were encountered: