Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix with writing lock follow-ups #187

Merged
merged 1 commit into from
Dec 10, 2024
Merged

fix with writing lock follow-ups #187

merged 1 commit into from
Dec 10, 2024

Conversation

crazy-max
Copy link
Collaborator

follow-up #185

@crazy-max crazy-max requested a review from tonistiigi December 9, 2024 23:50
@crazy-max
Copy link
Collaborator Author

argh test assertions looks broken now: https://github.com/tonistiigi/xx/actions/runs/12246474128/job/34162420457?pr=187#step:5:821

#86 7.061 # -- output differs --
#86 7.061 # expected (1 lines):
#86 7.061 #   x86_64-alpine-linux-musl
#86 7.061 # actual (2 lines):
#86 7.061 #   /work
#86 7.061 #   x86_64-alpine-linux-musl
#86 7.061 # --

crazy-max
crazy-max commented Dec 10, 2024
View reviewed changes
src/xx-apk
@@ -10,7 +10,7 @@ if [ -z "$XX_APK_NOLOCK" ]; then
elif [ ! -d /var/lock ]; then
mkdir -p /var/lock
fi
cd -
cd - >/dev/null
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tonistiigi figured this out, thanks!

Didn't know cd could output 😰

@tonistiigi tonistiigi merged commit 88f4f36 into tonistiigi:master Dec 10, 2024
25 of 27 checks passed
@crazy-max crazy-max deleted the readlink-lock-fixes branch December 10, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crazy-max @tonistiigi