Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update alpine to 3.21 #174

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Conversation

crazy-max
Copy link
Collaborator

No description provided.

@crazy-max crazy-max requested a review from tonistiigi December 6, 2024 14:41
@crazy-max
Copy link
Collaborator Author

crazy-max commented Dec 6, 2024

https://github.com/tonistiigi/xx/actions/runs/12200741186/job/34037574118?pr=174#step:5:783

 2.509 not ok 4 cross
2.510 # (in test file test-apk.bats, line 40)
2.512 #   `[ -f "/$(xx-info)/lib/libz.so.1" ]' failed

Seems since 3.21 it has moved to /usr/lib: https://pkgs.alpinelinux.org/contents?file=libz.so.1&path=&name=&branch=edge&repo=&arch=

@crazy-max
Copy link
Collaborator Author

crazy-max commented Dec 6, 2024

https://github.com/tonistiigi/xx/actions/runs/12201048147/job/34038587244#step:5:869

Looks like the arch has changed for i386:

 #85 55.68 # (from function `testHelloGO' in file test-go.bats, line 241,
#85 55.68 #  in test file test-go.bats, line 306)
#85 55.68 #   `testHelloGO' failed
#85 55.68 # file /tmp/a.out does not match expected target architecture 386: ELF 32-bit LSB executable, Intel i386, version 1 (SYSV), statically linked, Go BuildID=tlJHujLf8JLPAF5dYPfF/rijSNAaw8swSPvNg4IGt/4-GT7PqK9YJ69YYFBQrl/Hp7UJLaeCGcsmukHOQlY, with debug_info, not stripped

Expected Intel 80386 but got Intel i386.

@crazy-max crazy-max force-pushed the alpine-321 branch 2 times, most recently from 2de9dd9 to 37d71e5 Compare December 6, 2024 15:26
@crazy-max
Copy link
Collaborator Author

image

These ones are not related, should be fixed in another PR.

@tonistiigi
Copy link
Owner

These ones are not related, should be fixed in another PR.

Agree, but we should fix that issue before merging this.

@tonistiigi
Copy link
Owner

should also add new cases to https://github.com/tonistiigi/xx/blob/master/src/test-verify.bats

@crazy-max crazy-max force-pushed the alpine-321 branch 2 times, most recently from d53be5f to 126cdb9 Compare December 9, 2024 18:41
@crazy-max crazy-max merged commit b0cde9e into tonistiigi:master Dec 9, 2024
25 of 27 checks passed
@crazy-max crazy-max deleted the alpine-321 branch December 9, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants