Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fixes for go tests #137

Merged
merged 3 commits into from
Jan 5, 2024
Merged

tests: fixes for go tests #137

merged 3 commits into from
Jan 5, 2024

Conversation

tonistiigi
Copy link
Owner

No description provided.

src/test-go.bats Outdated
}

teardown_file() {
for p in linux/amd64 linux/arm64 linux/ppc64le linux/s390x linux/386 linux/arm/v7 linux/arm/v6; do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some platforms are missing?

xx/docker-bake.hcl

Lines 125 to 139 in 263a0bd

platforms = [
"linux/386",
"linux/amd64",
"linux/arm64",
"linux/arm/v5",
"linux/arm/v6",
"linux/arm/v7",
"linux/mips",
"linux/mipsle",
"linux/mips64",
"linux/mips64le",
"linux/ppc64le",
"linux/s390x",
"linux/riscv64"
]

@@ -26,9 +26,9 @@ xxadd() {

xxdel() {
if [ -f /etc/alpine-release ]; then
xx-apk add "$@" 2>/dev/null || true
xx-apk del "$@" 2>/dev/null || true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@crazy-max
Copy link
Collaborator

Small lint issue: https://github.com/tonistiigi/xx/actions/runs/7419055876/job/20187947405?pr=137#step:3:267

  > [shfmt-validate validate 1/1] RUN --mount=target=.   shfmt -ln posix -i 2 -ci -d . &&   for f in */test-*.bats; do shfmt -ln bats -i 2 -ci -d "$f" || return; done;:
0.176 --- src/test_helper.bash.orig
0.176 +++ src/test_helper.bash
0.176 @@ -80,7 +80,6 @@
0.176  
0.176  versionGTE() { test "$(printf '%s\n' "$@" | sort -V | tail -n 1)" = "$1"; }
0.176  
0.176 -
0.176  supportRiscVGo() {
0.176    versionGTE "$(go version | awk '{print $3}' | sed 's/^go//')" "1.14"
0.176  }

Single/double quotes have changed in the output.

Signed-off-by: Tonis Tiigi <[email protected]>
@crazy-max crazy-max merged commit c4ed410 into master Jan 5, 2024
22 of 24 checks passed
@crazy-max crazy-max deleted the go-test-fixes branch January 5, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants