Revert "Migrate off of gogo/protobuf" #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bea810c. Signed-off-by: CrazyMax <[email protected]>
jedevc
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Thanks @crazy-max 🎉 This should definitely unblock the fsutil fixes in buildkit 🥳
We should re-open the PR to bring this back as soon as this merges - and just mark it as do-not-merge until we're ready to take it.
tonistiigi
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to docker/buildx#2207 (comment)
This reverts commit bea810c.
This is to avoid breaking with downstream projects using fsutil while we wait for it to be implemented downstream on BuildKit in moby/buildkit#4422. We can bring it back as a PR when this one is merged so we can test from a fork instead. (cc @kzys @sipsma @jedevc)