Fix cross-device copy failing on macOS#170
Merged
tonistiigi merged 1 commit intotonistiigi:masterfrom Jan 29, 2024
Merged
Conversation
slonopotamus
added a commit
to darwin-containers/buildkit
that referenced
this pull request
Nov 12, 2023
slonopotamus
added a commit
to darwin-containers/moby
that referenced
this pull request
Nov 14, 2023
slonopotamus
added a commit
to darwin-containers/buildkit
that referenced
this pull request
Dec 23, 2023
slonopotamus
added a commit
to darwin-containers/buildkit
that referenced
this pull request
Dec 23, 2023
tonistiigi
reviewed
Jan 5, 2024
Owner
tonistiigi
left a comment
tonistiigi
left a comment
There was a problem hiding this comment.
LGTM but not sure why the CI does not start here.
DCO missing btw.
Downstream issue: https://github.com/macOScontainers/rund/issues/28 Signed-off-by: Marat Radchenko <marat@slonopotamus.org>
slonopotamus
force-pushed
the
darwin-cross-device-copy
branch
from
4e3df80 to
9ff8718
Compare
Contributor
Author
Added |
tonistiigi
approved these changes
Jan 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downstream issue: darwin-containers/buildkit#1