Add support for always overwriting existing paths#169
Merged
tonistiigi merged 1 commit intotonistiigi:masterfrom Nov 22, 2023
Merged
Add support for always overwriting existing paths#169tonistiigi merged 1 commit intotonistiigi:masterfrom
tonistiigi merged 1 commit intotonistiigi:masterfrom
Conversation
Before this, copy would always refuse to replace an existing path in the dest with something from the source of a different type. E.g. if there was a symlink at the dest, you'd get an error if copying src meant replacing the symlink w/ a directory. This is the right default behavior but there are situations in which callers may want to opt in to instead always replacing what's in dest with what's in source. This adds an option to enable that behavior. Signed-off-by: Erik Sipsma <erik@sipsma.dev>
Contributor
Author
|
ping @tonistiigi |
tonistiigi
approved these changes
Nov 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this, copy would always refuse to replace an existing path in the dest with something from the source of a different type. E.g. if there was a symlink at the dest, you'd get an error if copying src meant replacing the symlink w/ a directory.
This is the right default behavior but there are situations in which callers may want to opt in to instead always replacing what's in dest with what's in source.
This adds an option to enable that behavior.
cc @tonistiigi @jedevc PTAL, if we're good with adding this option I'll follow up with adding this option to LLB's
CopyInfotoo.