Always use buf in CopyBuffer#144
Merged
tonistiigi merged 1 commit intotonistiigi:masterfrom Jan 5, 2023
Merged
Conversation
CopyBuffer may not always use the provided buffer, in the case that the src implements WriterTo. So, in the case that the io.ReadCloser returned by fs.Open implements this method, the packet size limit will not be enforced, creating an oversized packet that results in an error on the receiver. To avoid this, we can create an anonymous structure to wrap the src, which prevents the shortcut taken by the standard library. Signed-off-by: Justin Chadwell <me@jedevc.com>
Collaborator
Author
|
@tonistiigi suggested adding a for loop with an |
tonistiigi
approved these changes
Jan 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CopyBuffer may not always use the provided buffer, in the case that the src implements WriterTo. So, in the case that the io.ReadCloser returned by fs.Open implements this method, the packet size limit will not be enforced, creating an oversized packet that results in an error on the receiver.
To avoid this, we can create an anonymous structure to wrap the src, which prevents the shortcut taken by the standard library.
I'm not 100% sure of the approach for this, maybe we should write our own
Copymethod to circumvent this issue instead?cc @crazy-max