Merged
Conversation
shouze
reviewed
Sep 15, 2017
walker.go
Outdated
| type WalkOpt struct { | ||
| IncludePaths []string // todo: remove? | ||
| ExcludePatterns []string | ||
| Filter func(*Stat) bool |
There was a problem hiding this comment.
As it’s possible to mutate the Stat struct... I’m not sure that Filter is self descriptive enough. It’s more close to map/reduce in fact.
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
walker-filter
branch
from
2c1f585 to
435da36
Compare
|
@tonistiigi back to work - can you confirm that to reset uid/gid to 0 when docker image build is in stream mode, I have to patch buildkit sendDiffCopy to pass a had hoc Also, can you confirm it will based on |
alexcb
pushed a commit
to alexcb/fsutil
that referenced
this pull request
Mar 3, 2023
Acb/update fsutil
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows overriding and filtering walked files, for example for resetting uid/gid.
cc @shouze
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com