Devcontainer + Fix python 3.13 warning#119
Open
QHivert wants to merge 2 commits intotonioo:masterfrom
Open
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #119 +/- ##
=======================================
Coverage 87.60% 87.60%
=======================================
Files 10 10
Lines 2041 2041
=======================================
Hits 1788 1788
Misses 253 253 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tonioo
reviewed
Apr 22, 2025
| @@ -0,0 +1,19 @@ | |||
| FROM python:3.13-slim | |||
Owner
There was a problem hiding this comment.
Do you think you could use an alpine based image instead?
Owner
|
@QHivert Any news about this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I'm planning to make some PR to add missing functionalities.
To do so, I'm using a devcontainer and wonder if you'll be interested to have it on your repo.
Besides, using pyhton 3.13, there were some warning when importing modules, as you can see below:
I've fixed them in this PR too. But if you don't want the devcontainer, I can remove it from the PR and just put the fixes.
Also, if you want me to open an issue before making a PR ask away!
Cheers,
Quentin