Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: rename 'partials/header.tpl.php' file #33

Closed
msacchetti opened this issue Aug 2, 2017 · 2 comments
Closed

Suggestion: rename 'partials/header.tpl.php' file #33

msacchetti opened this issue Aug 2, 2017 · 2 comments
Labels
enhancement
Milestone
3.0.0

Comments

@msacchetti
Copy link

When using an IDE like PHPStorm it gets confusing having two "header.tpl.php" files.

Suggestion would be to change the 'partials/header.tpl.php" to something like 'post-header.tpl.php"

Thanks!
@jedrzejchalubek
Copy link
Collaborator

I think it would be better to rename layouts/header.tpl.php to maybe layouts/head.tpl.php(?). That way we will not be too specific.

Of course, a structure of the .tpl.php files is just starting boilerplate. You are free to change it to your needs :)

@jedrzejchalubek jedrzejchalubek added this to the 2.1.0 milestone Aug 3, 2017
@msacchetti
Copy link
Author

Makes sense to me, thanks

jedrzejchalubek added a commit that referenced this issue Sep 14, 2017
@jedrzejchalubek
Suggestion: rename 'partials/header.tpl.php' file #33
f0aee91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@jedrzejchalubek @msacchetti