Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Device stats metrics filter_duration always is 0 #514

Closed
sbengo opened this issue Jan 13, 2022 · 0 comments · Fixed by #518
Closed

[Bug] Device stats metrics filter_duration always is 0 #514

sbengo opened this issue Jan 13, 2022 · 0 comments · Fixed by #518

Comments

@sbengo
Copy link
Collaborator

sbengo commented Jan 13, 2022

After the refactor of core logic to gather metrics, on version 0.12.0+ (now all the logic remains on the measurement instead of the device), the metric filter_duration seems to have some problem and always is sending 0 as the value, even if the log is showing the correct information.

Example:

time="2022-01-11 16:40:00" level=info msg="snmp INIT runtime measurements/filters took [402.449745ms] " device=X.X.X.X measurement=DLINK_IfCounterStatistics

> select filter_duration from selfmon_device_stats
name: selfmon_device_stats
time                   filter_duration
----                   ---------------
2022-01-11T 16:40:00Z  0
sbengo added a commit that referenced this issue Feb 15, 2022
@sbengo
remove resetStats from GatherOnce
1f356e9 
When the measruement tries to gather attached metrics is using the
GatherOnce function which was resetting measurement stats

This behaviour was causing that filter or other stats could be removed
based on the order of execution.

This PR removes the ResetStats call to delegate into the upper function
in order to control and manage stats behaviour, fixes #514
@sbengo sbengo mentioned this issue Feb 15, 2022
Merged
toni-moreno added a commit that referenced this issue Feb 15, 2022
@toni-moreno
Merge pull request #518 from toni-moreno/fix/filter_duration_stats
69056a9 
Fix #514 , filter_duration stats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #514 , filter_duration stats toni-moreno/snmpcollector
1 participant
@sbengo