A series of FunC improvements #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
EmelyanenkoK
commented
May 19, 2022
•
EmelyanenkoK
commented
- FunC incorrectly handles while(false) loops #377
- FunC incorreclty generate code for ifelse branches #374
- FunC incorrectly return from condition in inline functions #370
- Asm.fif: splitting of large function bodies incorrectly interfere with inlines #375
- Allow unbalanced if/else branches
Fix incorrect ifelse branch code generation
Func inline return
…inline-return # Conflicts: # crypto/func/codegen.cpp
EmelyanenkoK
added a commit
that referenced
this pull request
Aug 4, 2022
* Don't use IFJMP/IFNOTJMP in inline functions * Fix incorrect ifelse branch code generation #374 * Make generate_code_all clearer * Don't replace IFJMP with IF in inner blocks in inline functions * Allow unbalance if/else by using RETALT * Fix wrong PUSHCONT * Bugfix in IF code generation for inline functions * Fix unbalanced if/else * Bugfix and improvements in code generation * Fix analyzing while(0) in func #377 * FunC and Asm.fif: Fix inlining large functions #375 Co-authored-by: SpyCheese <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.