Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about method return type changes #122

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ivan-makarenkov
Copy link

This changes fix the issue:
#54

Copy link
Owner

@tomzx tomzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Most of this code should be reusable to check the return type of functions as well, so feel free to create a separate PR for that if you're interested!

src/PHPSemVerChecker/Analyzer/ClassMethodAnalyzer.php Outdated Show resolved Hide resolved
src/PHPSemVerChecker/Analyzer/ClassMethodAnalyzer.php Outdated Show resolved Hide resolved
src/PHPSemVerChecker/Analyzer/ClassMethodAnalyzer.php Outdated Show resolved Hide resolved
src/PHPSemVerChecker/Analyzer/ClassMethodAnalyzer.php Outdated Show resolved Hide resolved
src/PHPSemVerChecker/Analyzer/ClassMethodAnalyzer.php Outdated Show resolved Hide resolved
@ivan-makarenkov
Copy link
Author

I will create PR for a function at this weekend.

@ivan-makarenkov
Copy link
Author

Hello, I've added the function functionality here, please check it again. If there is some other change what I should do, write me here.

@anyt
Copy link

anyt commented Feb 23, 2022

Hi @tomzx,
Is there anything we can do to help with approving this PR?

@anyt
Copy link

anyt commented Jun 19, 2023

Hi @tomzx,
any news on the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants