Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup TZStackViewAlignment #60

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

fbartho
Copy link

@fbartho fbartho commented Nov 25, 2015

This PR updates TZStackViewAlignment to match UIStackViewAlignment and has some minor updates for iOS deprecations / consistency in documentation & test project.

Background

We noticed some discrepancies between the functionality of iOS 9.x UIStackView and iOS 8.x TZStackView. Specifically, we noticed that the following did not work as expected:

stack.alignment = UIStackViewAlignmentCenter;

Things discovered:

  1. TZStackViewAlignment had a different order of enum values than UIStackViewAlignment. This mismatch meant that the above assignment didn't go as planned.
  2. The code was using deprecated methods addConstraint()/addConstraints()
  3. The code was using other methods that required 8.x support.
  4. The xcodeproj was set to deployment target of 8.0, but the README.md claimed 7.x support.

These were all brought to consistency in this PR, along with using NSLayoutConstraint.activateConstraints()

…settings, & update the deployment target to the lowest supported by the code.
… -- The enum values were in the wrong order, some were concrete values rather than aliases.
…ct adding of NSLayoutConstraints to NSLayoutConstraint.activateConstraints.
@fbartho
Copy link
Author

fbartho commented Nov 30, 2015

Please see #63 instead of this PR if iOS 7 support is important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant