Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tvOS #48

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

nuudles
Copy link

@nuudles nuudles commented Oct 19, 2015

I needed a UIStackView in some shared code between my tvOS app and an iOS app, so I've gone ahead and added tvOS podspec support for TZStackView and it seems to work great.

@iGranDav
Copy link
Collaborator

@tomvanzummeren is there any reason for not merging this PR?

@tomvanzummeren
Copy link
Owner

Not really, other than I have no time right now to process the whole list of merge requests for TZStackView and release a new cocoapods version etc.

@iGranDav
Copy link
Collaborator

Ok do not hesitate to provide contributor rights if you need help to maintain and test this great library.

@tomvanzummeren
Copy link
Owner

Hey @iGranDav , would you really like to help me maintain this library? I can give you contributor rights if you're still interested!

@iGranDav
Copy link
Collaborator

Hello @tomvanzummeren I would be happy to test and merge some PR but I have strongly limited ressources to test under iOS 7

@tomvanzummeren
Copy link
Owner

@iGranDav well, thanks to one of the pull requests I merged in the past, the library is no longer compatible with iOS 7 anyway. So you would not be making things worse.

But isn't iOS 7 available anymore as a Simulator?

@iGranDav
Copy link
Collaborator

@tomvanzummeren not really supported officially and you need to have Xcode 6.4. But in any case it doesn't work that way because you will be then building under SDK 8. And we want to test on iOS 7 with a SDK 9 build.

@tomvanzummeren
Copy link
Owner

@iGranDav ok I agree, so it won't be a 100% covering test if you test with SDK 8. But it will be a lot better than NOT doing any testing, right?

Best case scenario: you end up restoring iOS 7 support
Worst case scenario: everything stays the same (no support for iOS 7)

Are you up for it?

@iGranDav
Copy link
Collaborator

Let's do this 👍

@tomvanzummeren
Copy link
Owner

I made you a collaborator!

@iGranDav
Copy link
Collaborator

Thanks! I'll be merging this tested one first :)

@tomvanzummeren
Copy link
Owner

aight! good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants