-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for tvOS #48
base: master
Are you sure you want to change the base?
Conversation
@tomvanzummeren is there any reason for not merging this PR? |
Not really, other than I have no time right now to process the whole list of merge requests for TZStackView and release a new cocoapods version etc. |
Ok do not hesitate to provide |
Hey @iGranDav , would you really like to help me maintain this library? I can give you contributor rights if you're still interested! |
Hello @tomvanzummeren I would be happy to test and merge some PR but I have strongly limited ressources to test under iOS 7 |
@iGranDav well, thanks to one of the pull requests I merged in the past, the library is no longer compatible with iOS 7 anyway. So you would not be making things worse. But isn't iOS 7 available anymore as a Simulator? |
@tomvanzummeren not really supported officially and you need to have Xcode 6.4. But in any case it doesn't work that way because you will be then building under SDK 8. And we want to test on iOS 7 with a SDK 9 build. |
@iGranDav ok I agree, so it won't be a 100% covering test if you test with SDK 8. But it will be a lot better than NOT doing any testing, right? Best case scenario: you end up restoring iOS 7 support Are you up for it? |
Let's do this 👍 |
I made you a collaborator! |
Thanks! I'll be merging this tested one first :) |
aight! good luck! |
I needed a
UIStackView
in some shared code between my tvOS app and an iOS app, so I've gone ahead and added tvOS podspec support forTZStackView
and it seems to work great.